Skip to content

NativeSender relies on obsolete WebRequest.Create #37

Open
@MKuenzi

Description

@MKuenzi

Hi, I noticed when looking through the code that NativeSender.cs relies on WebRequest.Create to make it's Http requests.

Microsoft recommends you switch this to use HttpClient:
https://learn.microsoft.com/en-us/dotnet/api/system.net.webrequest.create?view=net-7.0#system-net-webrequest-create(system-string)

It would be nice to have an overload in your API where I can provide my own instance of HttpClient, as that class is intended to only be initialized once:

https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclient?view=net-7.0#instancing

I'm evaluating Smarty right now for use in our application. If possible I would like to know if you are on board with making these changes and what your timeframe would be for implementing them?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions