Skip to content

Use VerificationURIComplete if present for OIDC device flow #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
virtualdxs opened this issue May 17, 2025 · 0 comments · May be fixed by #1430
Open

Use VerificationURIComplete if present for OIDC device flow #1424

virtualdxs opened this issue May 17, 2025 · 0 comments · May be fixed by #1430
Assignees
@hslatman
Labels
enhancement good first issue needs triage Waiting for discussion / prioritization by team

Comments

@virtualdxs
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Right now, even if the IdP provides a verification_uri_complete parameter, step-cli ignores it. It should instead prefer it if present.

Why is this needed?

It makes the login flow less tedious, as one only needs to click the link and then click yes in their browser, rather than copy the code, click the link, paste the code, hit enter, click yes.

See kubelogin for an example of a somewhat similar tool handling the same circumstance.
@virtualdxs virtualdxs added enhancement needs triage Waiting for discussion / prioritization by team labels May 17, 2025
virtualdxs added a commit to virtualdxs/step-cli that referenced this issue May 29, 2025
@virtualdxs
Prefer VerificationURIComplete if present
f0b41c9 
In the OIDC Device Authorization Flow in command/oauth, present the user
with VerificationURIComplete rather than VerificationURI if present, so
that the user doesn't have to manually type the code when using an IdP
that provides this feature.

Fixes smallstep#1424
@virtualdxs virtualdxs linked a pull request May 29, 2025 that will close this issue
Open
@hslatman hslatman self-assigned this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hslatman hslatman

Labels
enhancement good first issue needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer VerificationURIComplete if present virtualdxs/step-cli
2 participants
@hslatman @virtualdxs