Merge pull request #77 from shvbsle/editrs

feat: key binding to edit kubernetes resoruce

Author: shvbsle

internal/tui/commands.go

@@ -559,6 +559,66 @@ func (m *Model) getResourceYaml() tea.Cmd {
 	}
 }
 
+// editCurrentResource opens the selected resource in an external editor using kubectl edit.
+func (m *Model) editCurrentResource() tea.Cmd {
+	if len(m.resources) == 0 {
+		return func() tea.Msg {
+			return commandErrMsg{message: "no resource selected"}
+		}
+	}
+
+	actualIdx := m.paginator.Page*m.paginator.PerPage + m.table.Cursor()
+	if actualIdx >= len(m.resources) {
+		return func() tea.Msg {
+			return commandErrMsg{message: "invalid selection"}
+		}
+	}
+
+	selectedResource := m.resources[actualIdx]
+
+	// Extract name and namespace from the selected row
+	var selectedName, selectedNamespace string
+	if nameIndex, ok := k8s.NameColumn(m.table.Columns()); ok {
+		selectedName = selectedResource[nameIndex]
+	}
+	if namespaceIndex, ok := k8s.NamespaceColumn(m.table.Columns()); ok {
+		selectedNamespace = selectedResource[namespaceIndex]
+	}
+
+	// Use the current namespace if no namespace column exists (cluster-scoped resources)
+	if selectedNamespace == "" {
+		selectedNamespace = m.currentNamespace
+	}
+
+	log.G().Info("editing resource", "gvr", m.currentGVR, "name", selectedName, "namespace", selectedNamespace)
+
+	// Build kubectl edit command
+	resourceType := m.currentGVR.Resource
+	var args []string
+	if selectedNamespace != "" && selectedNamespace != metav1.NamespaceAll {
+		args = []string{"edit", resourceType, selectedName, "-n", selectedNamespace}
+	} else {
+		args = []string{"edit", resourceType, selectedName}
+	}
+
+	// Create the command that will run in the terminal
+	cmd := exec.Command("kubectl", args...)
+
+	// Use tea.ExecProcess to suspend the TUI, run kubectl edit, and resume when done
+	return tea.ExecProcess(cmd, func(err error) tea.Msg {
+		if err != nil {
+			log.G().Error("failed to edit resource", "error", err)
+			return commandErrMsg{message: fmt.Sprintf("failed to edit resource: %v", err)}
+		}
+		// After editing, return message to trigger resource reload
+		log.G().Info("resource edit completed")
+		return resourceEditedMsg{
+			resourceName: selectedName,
+			resourceType: resourceType,
+		}
+	})
+}
+
 // executeCtxCommand handles the ctx command for listing and switching Kubernetes contexts.
 func (m *Model) executeCtxCommand(args []string) tea.Cmd {
 	// If no arguments, list all available contexts

internal/tui/keys.go

@@ -26,6 +26,7 @@ type keyMap struct {
 	// Resource actions
 	Describe key.Binding
 	YamlView key.Binding
+	Edit     key.Binding
 }
 
 // newKeyMap creates a new keyMap with all bindings configured
@@ -111,5 +112,9 @@ func newKeyMap() keyMap {
 			key.WithKeys("y"),
 			key.WithHelp("y", "yaml"),
 		),
+		Edit: key.NewBinding(
+			key.WithKeys("e"),
+			key.WithHelp("e", "edit"),
+		),
 	}
 }

internal/tui/model.go

@@ -133,6 +133,11 @@ type resourceYamlMsg struct {
 	gvr          schema.GroupVersionResource
 }
 
+type resourceEditedMsg struct {
+	resourceName string
+	resourceType string
+}
+
 type contextsLoadedMsg struct {
 	contexts []k8s.OrderedResourceFields
 }
@@ -529,6 +534,17 @@ func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		m.commandSuccess = ""
 		return m, nil
 
+	case resourceEditedMsg:
+		// Show success message
+		m.commandSuccess = fmt.Sprintf("Successfully edited %s/%s", msg.resourceType, msg.resourceName)
+		// Reload the current resources to reflect any changes
+		return m, tea.Batch(
+			m.loadResourcesWithNamespace(m.currentGVR, m.currentNamespace, metav1.ListOptions{}),
+			tea.Tick(5*time.Second, func(t time.Time) tea.Msg {
+				return clearCommandSuccessMsg{}
+			}),
+		)
+
 	case launchPluginMsg:
 		m.pluginToLaunch = msg.plugin
 		return m, tea.Quit
@@ -847,6 +863,21 @@ func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 					m.getResourceYaml(),
 					m.requireConnection,
 				)
+			case "e":
+				// Edit the currently selected resource
+				if m.currentGVR.Resource == k8s.ResourceLogs ||
+					m.currentGVR.Resource == k8s.ResourceDescribe ||
+					m.currentGVR.Resource == k8s.ResourceYaml ||
+					m.currentGVR.Resource == k8s.ResourceContainers ||
+					m.currentGVR.Resource == k8s.ResourceAPIResources {
+					return m, nil // Can't edit these resource types
+				}
+				if !m.isConnected() {
+					m.err = fmt.Errorf("not connected to cluster. Use :reconnect")
+					return m, nil
+				}
+				// Edit command directly returns tea.ExecProcess, no need for commandWithPreflights
+				return m, m.editCurrentResource()
 			case "d":
 				// Describe the currently selected resource
 				if m.currentGVR.Resource == k8s.ResourceLogs ||

roadmap.md

@@ -4,7 +4,7 @@
 
 - [ ] **Search for pods/resources** ([#60](https://github.com/shvbsle/k10s/issues/60)) - Triggered by `/` keybinding. Opens a search box with live filtering - as the user types, the current view updates in real-time to show matching results
 - [x] **Switch between cluster contexts** ([#61](https://github.com/shvbsle/k10s/issues/61)) - Triggered by `:ctx` in command mode. Opens a context selector to switch between different kubeconfig contexts without leaving the TUI
-- [ ] **Edit manifests** ([#62](https://github.com/shvbsle/k10s/issues/62)) - Triggered by `e` keybinding when cursor is on any resource. Opens the resource manifest in the user's default editor (e.g., vim). Saving and closing the editor automatically applies the changes to the cluster
+- [x] **Edit manifests** ([#62](https://github.com/shvbsle/k10s/issues/62)) - Triggered by `e` keybinding when cursor is on any resource. Opens the resource manifest in the user's default editor (e.g., vim). Saving and closing the editor automatically applies the changes to the cluster
 - [x] **Describe output for resources** ([#63](https://github.com/shvbsle/k10s/issues/63)) - Triggered by `d` keybinding when cursor is on any resource. Renders `kubectl describe` output for the selected resource
 - [x] **YAML view for resources** - Triggered by `y` keybinding when cursor is on any resource. Renders the resource YAML manifest with syntax highlighting (bold keys), scrollable with arrow keys, line number toggle (`n`), and line wrapping toggle (`w`)
 - [ ] **Syntax highlighting for describe output** ([#64](https://github.com/shvbsle/k10s/issues/64)) - Add syntax highlighting to the describe output view for better readability