truly available payments for a change after the order is made are now returned from the backend (#3922)

Author: grossmannmartin

src/Model/Order/OrderPaymentsConfig.php

@@ -9,11 +9,11 @@
 class OrderPaymentsConfig
 {
     /**
-     * @param \Shopsys\FrameworkBundle\Model\Payment\Payment $currentPayment
+     * @param \Shopsys\FrameworkBundle\Model\Payment\Payment|null $currentPayment
      * @param \Shopsys\FrameworkBundle\Model\Payment\Payment[] $availablePayments
      */
     public function __construct(
-        public readonly Payment $currentPayment,
+        public readonly ?Payment $currentPayment,
         public readonly array $availablePayments,
     ) {
     }

src/Model/Order/OrderPaymentsConfigFactory.php

@@ -26,10 +26,25 @@ public function createForOrder(Order $order): OrderPaymentsConfig
     {
         $payments = $this->paymentFacade->getVisibleForOrder($order);
 
-        $currentPayment = $order->getPayment();
+        $currentPayment = $order->isMaxTransactionCountReached() ? null : $order->getPayment();
+
+        if ($currentPayment !== null && !in_array($currentPayment, $payments, true)) {
+            $currentPayment = null;
+        }
+
         $availablePayments = array_filter(
             $payments,
-            static fn (Payment $payment) => $payment->getId() !== $currentPayment->getId(),
+            static function (Payment $payment) use ($order, $currentPayment) {
+                if ($payment->getId() === $currentPayment?->getId()) {
+                    return false;
+                }
+
+                if ($order->isMaxTransactionCountReached()) {
+                    return !$payment->isGatewayPayment();
+                }
+
+                return true;
+            },
         );
 
         return new OrderPaymentsConfig($currentPayment, $availablePayments);

src/Model/Resolver/Settings/MaxAllowedPaymentTransactionsQuery.php

@@ -108,9 +108,6 @@ OrderDecorator:
             lastExternalPaymentUrl:
                 type: "String"
                 description: "URL for accessing the last payment transaction on a gateway without invoking the new payment transaction. Depending on the payment status, user might see the payment details or even retry the transaction if possible."
-            paymentTransactionsCount:
-                type: "Int!"
-                description: "Count of the payment transactions related to the order"
             isPaid:
                 type: "Boolean!"
                 description: "Indicates whether the order is paid successfully with GoPay payment type"

src/Resources/config/graphql-types/ModelType/Order/OrderDecorator.types.yaml

@@ -4,8 +4,8 @@ OrderPaymentsConfigDecorator:
     config:
         fields:
             currentPayment:
-                type: "Payment!"
-                description: "Current payment method used in the order"
+                type: "Payment"
+                description: "Current payment method used in the order. Null if the original payment is not available anymore due to the reached limit of max payment transactions count."
             availablePayments:
                 type: "[Payment!]!"
-                description: "All available payment methods for the order (excluding the current one)"
+                description: "All currently available payment methods for the order (excluding the current one)"

src/Resources/config/graphql-types/ModelType/Order/OrderPaymentsConfig.types.yaml

@@ -8,10 +8,6 @@ SettingsDecorator:
                 type: "SeoSetting!"
                 resolve: "@=query('seoSettingsQuery')"
                 description: "Settings related to SEO"
-            maxAllowedPaymentTransactions:
-                type: Int!
-                resolve: "@=query('maxAllowedPaymentTransactionsQuery')"
-                description: "Max allowed payment transactions (how many times is user allowed to try the same payment)"
             pricing:
                 type: "PricingSetting!"
                 resolve: "@=query('pricingSettingsQuery')"