Parser's issue with scripts containing closing tags

[mnakalay]

Hello,
Whenever the page contains a script which contains a closing HTML tag, the parser gets it wrong and adds a closing </script> tag right in the middle

For instance this

$('<div class="bg-color-overlay"></div>').prependTo('body');

becomes this

$('<div class="bg-color-overlay"></script></div>').prependTo('body');

And breaks everything.

[shinsenter]

Dear Nour Akalay, That may not be a bug. You may fix this by escaping the backslash in close div tag in your script: $('<div class="bg-color-overlay"><\/div>').prependTo('body'); Best regards 2019年11月21日(木) 5:21 Nour Akalay <notifications@github.com>:

Hello, Whenever the page contains a script which contains a closing HTML tag, the parser gets it wrong and adds a closing </script> tag right in the middle For instance this $('<div class="bg-color-overlay"></div>').prependTo('body'); becomes this $('<div class="bg-color-overlay"></script></div>').prependTo('body'); And breaks everything. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#48?email_source=notifications&email_token=AAP4KR52ZMB5IHQBOVYZCALQUWL3HA5CNFSM4JPYZXZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H24VZOQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAP4KR5QA2NUOTB3UHPXBDDQUWL3HANCNFSM4JPYZXZA> .

-- Sent from mobile

[mnakalay]

I agree there are ways to modify the script to make it work. Having said so that is a totally acceptable jQuery piece of code so it's bound to happen. What is more the fact that the parser thinks it's ok to add a closing script tag in the middle of the script itself just feels like a bug. Just to be clear the problem is not with your code the problem is with PHP Dom parser.

…

On Thu, Nov 21, 2019, 00:35 Shin ***@***.***> wrote: Dear Nour Akalay, That may not be a bug. You may fix this by escaping the backslash in close div tag in your script: $('<div class="bg-color-overlay"><\/div>').prependTo('body'); Best regards 2019年11月21日(木) 5:21 Nour Akalay ***@***.***>: > Hello, > Whenever the page contains a script which contains a closing HTML tag, the > parser gets it wrong and adds a closing </script> tag right in the middle > > For instance this > > $('<div class="bg-color-overlay"></div>').prependTo('body'); > > becomes this > > $('<div class="bg-color-overlay"></script></div>').prependTo('body'); > > And breaks everything. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > < #48?email_source=notifications&email_token=AAP4KR52ZMB5IHQBOVYZCALQUWL3HA5CNFSM4JPYZXZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H24VZOQ >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAP4KR5QA2NUOTB3UHPXBDDQUWL3HANCNFSM4JPYZXZA > > . > -- Sent from mobile — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#48?email_source=notifications&email_token=AALLPQJJX5SDQEP43G2R6QLQUXCURA5CNFSM4JPYZXZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEWENAI#issuecomment-556549761>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALLPQJ5MPZQEKALSU7GRW3QUXCURANCNFSM4JPYZXZA> .

[shinsenter]

Merged #49
Thank you so much!