Merge pull request #62 from shinsenter/develop

Fixed custom_splash_screen bugs

Author: shinsenter

README.md

@@ -260,16 +260,17 @@ $options = [
   // Default: blank array
   'ignore_lazyload_texts'  => [],
 
-  // Do not lazy-load for tags containing
-  //   one of these CSS class names.
+  // Do not lazy-load for tags containing one of these CSS class names.
   // Default: blank array
   'ignore_lazyload_css_class'  => [],
 
-  // Do not lazy-load for tags containing
-  //   one of these CSS selectors.
+  // Do not lazy-load for tags matching one of these CSS selectors.
   // See: https://www.w3schools.com/cssref/css_selectors.asp
   // Default: blank array
-  'ignore_lazyload_css_selectors'  => [],
+  'ignore_lazyload_css_selectors'  => [
+    // 'header img',
+    // 'img#logo',
+  ],
 ];
 
 // Create a Defer object

composer.lock

@@ -3,7 +3,7 @@
   "author": "Mai Nhut Tan <[email protected]>",
   "license": "MIT",
   "dependencies": {
-    "@shinsenter/defer.js": "^2.4.0"
+    "@shinsenter/defer.js": "^2.4.1"
   },
   "scripts": {
     "cleanup": "rm -rf ./node_modules package-lock.json",

package-lock.json

@@ -189,7 +189,7 @@ public function precede($input)
 
             if ($this->parentNode instanceof DOMNode) {
                 foreach ($input as $node) {
-                    $this->parentNode->insertBefore($node, $this);
+                    $this->parentNode->insertBefore($this->_safeNode($node), $this);
                 }
             }
         }
@@ -211,6 +211,8 @@ public function follow($input)
 
             if ($this->parentNode instanceof DOMNode) {
                 foreach ($input as $node) {
+                    $node = $this->_safeNode($node);
+
                     if (is_null($this->nextSibling)) {
                         $this->parentNode->appendChild($node);
                     } else {
@@ -236,7 +238,7 @@ public function prependWith($input)
             }
 
             foreach ($input as $node) {
-                $this->insertBefore($node, $this->firstChild);
+                $this->insertBefore($this->_safeNode($node), $this->firstChild);
             }
         }
 
@@ -256,7 +258,7 @@ public function appendWith($input)
             }
 
             foreach ($input as $node) {
-                $this->appendChild($node);
+                $this->appendChild($this->_safeNode($node));
             }
         }
 
@@ -310,4 +312,22 @@ private function _pushAttrValue($name, $value, $addValue = false)
             }
         }
     }
+
+    /**
+     * @internal
+     *
+     * @param  \DOMNode|string   $input
+     * @return \DOMNode
+     */
+    private function _safeNode($input)
+    {
+        if ($input instanceof DOMNode) {
+            return $input;
+        }
+
+        $fragment = $this->document()->createDocumentFragment();
+        $fragment->appendXML($input);
+
+        return $fragment;
+    }
 }

package.json

@@ -376,16 +376,17 @@ public function getWellKnown3rd($useCache = true)
      *  // Default: blank array
      *  'ignore_lazyload_texts'  => [],
      *
-     *  // Do not lazy-load for tags containing
-     *  //   one of these CSS class names.
+     *  // Do not lazy-load for tags containing one of these CSS class names.
      *  // Default: blank array
      *  'ignore_lazyload_css_class'  => [],
      *
-     *  // Do not lazy-load for tags containing
-     *  //   one of these CSS selectors.
+     *  // Do not lazy-load for tags matching one of these CSS selectors.
      *  // See: https://www.w3schools.com/cssref/css_selectors.asp
      *  // Default: blank array
-     *  'ignore_lazyload_css_selectors'  => [],
+     *  'ignore_lazyload_css_selectors'  => [
+     *    // 'header img',
+     *    // 'img#logo',
+     *  ],
      *
      * @since  2.0.0
      * @return array