-
Notifications
You must be signed in to change notification settings - Fork 1.4k
selectAudioTrack() can break playback #8737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See #8738 (comment) |
@avelad |
In my case it is working correctly in Firefox, but it fails in Safari :( 8737.mp4 |
This is my test on Firefox: |
I've seen several things that could be improved. Every time we change the audio, we reset MSE when it's not necessary. ChangeType can be used, and it's much better from a user perspective. Safari doesn't support switching from audio/mp4 to audio/aac when using sequenceMode, so in some cases, we should transmux to avoid having to reset. I'll have the changes ready in PR later today. |
Uh oh!
There was an error while loading. Please reload this page.
Have you read the FAQ and checked for duplicate open issues?
yes
If the problem is related to FairPlay, have you read the tutorial?
no
What version of Shaka Player are you using?
the nightly version
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from
main
?yes
Are you using the demo app or your own custom app?
both
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
Chrome, Firefox and Safari on macOS 15
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_16x9/bipbop_16x9_variant.m3u8
What configuration are you using? What is the output of
player.getNonDefaultConfiguration()
?What did you do?
Open the video in demo. Then run:
wait for a few seconds
What did you expect to happen?
The video should still be playable.
What actually happened?
The video is stuck forever.
Are you planning to send a PR to fix it?
no
The text was updated successfully, but these errors were encountered: