-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Ad markers missing when using VMAP ad tag #8529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you using IMA or our custom VMAP support? |
IMA. But this seems to be case in both ways, at least on demo page, the "Use IMA" toggle doesn't change anything. |
It's a problem with the ad URL. Adding a random parameter at the end always works. I also see that the ad URL changes every so often when refreshing the page, so it must be related to something... |
You mean adtag URL? This doesn't seem to help for me. I tried both - giving value to correlator (but as far as I understand, if this is empty, IMA will fill it automatically) and adding additional key-value pair. But if this helps you, then for me it still seems to be related to loading time:
On older version (I have 4.7.11 set up) everything works. |
I've tried to reproduce the problem again with the main branch and I haven't been able to. I've used different throttlings in Chrome and everything works correctly, both with IMA and with Shaka's custom solution to support VMAP and VAST in Shaka :( |
Unfortunately, I still don't see midroll markers. Markers for pre- and postrolls are visible, but not for midrolls. Strange thing is that sometimes they appear. Without changing anything in the adURL or anywhere else. I'd say like about one of seven times. |
Uh oh!
There was an error while loading. Please reload this page.
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Not related
What version of Shaka Player are you using?
Latest, tested with 4.14.9 and 4.14.10
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Windows, Chrome
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
What configuration are you using? What is the output of
player.getNonDefaultConfiguration()
?What did you do?
When using VMAP ads ( sample tags can be used for testing: https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags#vmap-pre-,-mid-,-and-post-rolls,-single-ads ), the ad markers aren't displayed.
On occasions, they appear - it seems to be related, how fast the ads request is served.
What did you expect to happen?
Ad markers to be displayed on the timeline.
What actually happened?
Ad markers not visible most of the time; after some refreshes they appear.
Are you planning to send a PR to fix it?
No, don't have a solution.
The text was updated successfully, but these errors were encountered: