Skip to content

Ad markers missing when using VMAP ad tag #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andekas opened this issue Apr 29, 2025 · 6 comments
Open

Ad markers missing when using VMAP ad tag #8529

Andekas opened this issue Apr 29, 2025 · 6 comments
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs type: bug Something isn't working correctly
Milestone

Comments

@Andekas
Copy link

Andekas commented Apr 29, 2025

Have you read the FAQ and checked for duplicate open issues?

Yes

If the problem is related to FairPlay, have you read the tutorial?

Not related

What version of Shaka Player are you using?

Latest, tested with 4.14.9 and 4.14.10

Can you reproduce the issue with our latest release version?

Yes

Can you reproduce the issue with the latest code from main?

Yes

Are you using the demo app or your own custom app?

Both

If custom app, can you reproduce the issue using our demo app?

Yes

What browser and OS are you using?

Windows, Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

What did you do?

When using VMAP ads ( sample tags can be used for testing: https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags#vmap-pre-,-mid-,-and-post-rolls,-single-ads ), the ad markers aren't displayed.

On occasions, they appear - it seems to be related, how fast the ads request is served.

What did you expect to happen?

Ad markers to be displayed on the timeline.

What actually happened?

Ad markers not visible most of the time; after some refreshes they appear.

Are you planning to send a PR to fix it?

No, don't have a solution.

@Andekas Andekas added the type: bug Something isn't working correctly label Apr 29, 2025
@shaka-bot shaka-bot added this to the v4.15 milestone Apr 29, 2025
@avelad
Copy link
Member

avelad commented Apr 29, 2025

Are you using IMA or our custom VMAP support?

@avelad avelad added the component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs label Apr 29, 2025
@Andekas
Copy link
Author

Andekas commented Apr 29, 2025

IMA. But this seems to be case in both ways, at least on demo page, the "Use IMA" toggle doesn't change anything.

@avelad
Copy link
Member

avelad commented Apr 29, 2025

It's a problem with the ad URL. Adding a random parameter at the end always works. I also see that the ad URL changes every so often when refreshing the page, so it must be related to something...

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 29, 2025
@Andekas
Copy link
Author

Andekas commented Apr 30, 2025

You mean adtag URL? This doesn't seem to help for me. I tried both - giving value to correlator (but as far as I understand, if this is empty, IMA will fill it automatically) and adding additional key-value pair.

But if this helps you, then for me it still seems to be related to loading time:

  • Changing the URL goes past any cache, loading is slower (video is ready before ads) and thus markers are displayed
  • Using same URL, the response comes faster / from cache

On older version (I have 4.7.11 set up) everything works.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 30, 2025
@avelad
Copy link
Member

avelad commented May 12, 2025

I've tried to reproduce the problem again with the main branch and I haven't been able to. I've used different throttlings in Chrome and everything works correctly, both with IMA and with Shaka's custom solution to support VMAP and VAST in Shaka :(

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 12, 2025
@Andekas
Copy link
Author

Andekas commented May 13, 2025

Unfortunately, I still don't see midroll markers. Markers for pre- and postrolls are visible, but not for midrolls.

Strange thing is that sometimes they appear. Without changing anything in the adURL or anywhere else. I'd say like about one of seven times.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 13, 2025
@avelad avelad modified the milestones: v4.15, v4.16 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants