Skip to content

[Feature Request] "Humanize" quality selector #8319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarianoFacundoArch opened this issue Mar 21, 2025 · 6 comments
Open

[Feature Request] "Humanize" quality selector #8319

MarianoFacundoArch opened this issue Mar 21, 2025 · 6 comments
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P4 Nice to have / wishful thinking type: enhancement New feature or request
Milestone

Comments

@MarianoFacundoArch
Copy link
Contributor

MarianoFacundoArch commented Mar 21, 2025

Image

Our current quality selector looks outdated compared to the new approaches platforms like YouTube are doing for their mobile versions.
I think YouTube has found a great, understandable way for most users. Maybe we can create an option for Shaka UI that enables us to select what kind of menu we want to use.

The new menu would be like this:

Image

Basically, Auto does what we already have; Higher would go to the highest available quality, and Data saver to the lowest (maybe we can put a configurable value in the UI config, so it will go to the nearest to that value for each configured selection). Advanced opens our current selectorwhere you can specify specifically choose the quality.

I think this can be a great improvement!

@MarianoFacundoArch MarianoFacundoArch added the type: enhancement New feature or request label Mar 21, 2025
@shaka-bot shaka-bot added this to the Backlog milestone Mar 21, 2025
@absidue
Copy link

absidue commented Mar 21, 2025

It's actually more complicated than just highest or lowest on YouTube, my understanding is that it is still auto but with different maximum resolutions e.g. data saver will pick 360p as long as your connection is not dreadful.

Considering how many people complained when YouTube originally introduced that, I really don't think it should be the default in shaka-player, you can always write your own UI components to do that.

@avelad
Copy link
Member

avelad commented Mar 21, 2025

The UI API allows you to write your own components, in this case I think this shouldn't be part of Shaka Player, sorry.

@avelad avelad added the status: will not implement The team chooses not to implement this enhancement label Mar 21, 2025
@avelad avelad removed this from the Backlog milestone Mar 21, 2025
@MarianoFacundoArch
Copy link
Contributor Author

Hi @avelad !
Is it possible to somehow rewrite just that part without having to reimplement the whole overflow menu thing?
That's the limitation I see, but maybe it is possible.

@avelad
Copy link
Member

avelad commented Mar 21, 2025

Hi @avelad ! Is it possible to somehow rewrite just that part without having to reimplement the whole overflow menu thing? That's the limitation I see, but maybe it is possible.

@joeyparrish Do you have any idea?

@shaka-bot shaka-bot added this to the Backlog milestone Mar 21, 2025
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 24, 2025
@joeyparrish
Copy link
Member

@MarianoFacundoArch, I'd be happy to open it up if the current API/config is too restrictive to do what you want here. Do you have any suggestions?

@joeyparrish joeyparrish added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this component: UI The issue involves the Shaka Player UI and removed status: will not implement The team chooses not to implement this enhancement status: waiting on response Waiting on a response from the reporter(s) of the issue labels Mar 24, 2025
@MarianoFacundoArch
Copy link
Contributor Author

Hi @joeyparrish ,
I think we should have an option to work like youtube for quality selection. In a simple way, higher data quality >> you can select the nearest to what value will be selected.
Data saver>> same, you can select, for example 240p, and if there is just 360 p it will go to 360 p.

auto: the current auto
advanced: opens the current menu where you can select.

That'd be greatly enough!

@avelad avelad added the priority: P4 Nice to have / wishful thinking label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P4 Nice to have / wishful thinking type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants