Skip to content

build.py --force needed when customizations change #759

@joeyparrish

Description

@joeyparrish
Member

When customizing the build as detailed in the Plugins and Customizing the Build Tutorial, if you change the build parameters like so:

# Build without polyfills:
python build/build.py +@complete -@polyfill
# Build without polyfills or text parsers:
python build/build.py +@complete -@polyfill -@text

The second build will not happen without --force. Instead, you get this message:

Compiling the library...
No changes detected, not building.  Use --force to override.

Ideally, we could detect that the build parameters have changed and rebuild anyway.

Activity

added this to the Backlog milestone on Apr 25, 2017
joeyparrish

joeyparrish commented on Apr 25, 2017

@joeyparrish
MemberAuthor

Design from @TheModMaker:

  1. Next to each build, output a manifest of the input JS files that went into that build.
  2. When asked to build, check for this manifest and compare it to the list of inputs files for this build.
  3. If the list has changed, rebuild regardless of changes to the source files.
modified the milestones: Backlog, v2.4.0 on Oct 8, 2017
modified the milestones: v2.4.0, Backlog on Dec 4, 2017
modified the milestones: Backlog, Backlog 2 on Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @joeyparrish@avelad

        Issue actions

          build.py --force needed when customizations change · Issue #759 · shaka-project/shaka-player