fix(DASH): Always fit segments to period boundaries on VOD (#8825)

Fixes #8774

Author: tykus160

lib/dash/segment_template.js

@@ -173,6 +173,7 @@ shaka.dash.SegmentTemplate = class {
 
         shaka.log.debug(`Creating TSI with end ${periodEnd}`);
         segmentIndex = new TimelineSegmentIndex(
+            context.dynamic,
             info,
             context.representation.originalId,
             context.bandwidth,
@@ -188,7 +189,8 @@ shaka.dash.SegmentTemplate = class {
       } else {
         const tsi = /** @type {!TimelineSegmentIndex} */(segmentIndex);
         tsi.appendTemplateInfo(
-            info, periodStart, periodEnd, initSegmentReference);
+            info, periodStart, periodEnd, initSegmentReference,
+            context.dynamic);
 
         const availabilityStart =
           context.presentationTimeline.getSegmentAvailabilityStart();
@@ -232,7 +234,7 @@ shaka.dash.SegmentTemplate = class {
           if (segmentIndex instanceof shaka.dash.TimelineSegmentIndex &&
               segmentIndex.isEmpty()) {
             segmentIndex.appendTemplateInfo(info, periodStart,
-                periodEnd, initSegmentReference);
+                periodEnd, initSegmentReference, context.dynamic);
           }
           return Promise.resolve(segmentIndex);
         },
@@ -778,7 +780,7 @@ shaka.dash.SegmentTemplate = class {
  */
 shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
   /**
-   *
+   * @param {boolean} dynamic
    * @param {!shaka.dash.SegmentTemplate.SegmentTemplateInfo} templateInfo
    * @param {?string} representationId
    * @param {number} bandwidth
@@ -791,11 +793,14 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
    * @param {number} segmentSequenceCadence
    * @param {number} timeline
    */
-  constructor(templateInfo, representationId, bandwidth, getBaseUris,
+  constructor(dynamic, templateInfo, representationId, bandwidth, getBaseUris,
       urlParams, periodStart, periodEnd, initSegmentReference,
       aesKey, segmentSequenceCadence, timeline) {
     super([]);
 
+    /** @private {boolean} */
+    this.dynamic_ = dynamic;
+
     /** @private {?shaka.dash.SegmentTemplate.SegmentTemplateInfo} */
     this.templateInfo_ = templateInfo;
 
@@ -897,9 +902,12 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
    * @param {number} periodStart
    * @param {number} periodEnd
    * @param {shaka.media.InitSegmentReference} initSegmentReference
+   * @param {boolean} dynamic
    */
-  appendTemplateInfo(info, periodStart, periodEnd, initSegmentReference) {
+  appendTemplateInfo(info, periodStart, periodEnd, initSegmentReference,
+      dynamic) {
     this.updateInitSegmentReference(initSegmentReference);
+    this.dynamic_ = dynamic;
     if (!this.templateInfo_) {
       this.templateInfo_ = info;
       this.periodStart_ = periodStart;
@@ -1091,7 +1099,7 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
       if (correctedPosition === this.getNumReferences() - 1 &&
           this.periodEnd_ !== Infinity) {
         // See https://github.com/shaka-project/shaka-player/issues/8672
-        if (Math.abs(segmentEnd - this.periodEnd_) > 0.1) {
+        if (this.dynamic_ && Math.abs(segmentEnd - this.periodEnd_) > 0.1) {
           segmentEnd = Math.min(segmentEnd, this.periodEnd_);
         } else {
           segmentEnd = this.periodEnd_;