add more tests for deserialization error

Author: rhysd

Cargo.lock

@@ -1,9 +1,9 @@
 [package]
 name = "keybinds"
-version = "0.0.4"
+version = "0.0.5"
 edition = "2021"
 authors = ["rhysd <[email protected]>"]
-description = "Platform&Framework-agnostic key bindings parser and dispatcher"
+description = "Platform&Framework-agnostic key binding (keyboard shortcut) parser and dispatcher"
 license = "MIT"
 homepage = "https://github.com/rhysd/keybinds-rs#readme"
 documentation = "https://docs.rs/keybinds"

Cargo.toml

@@ -6,7 +6,7 @@ keybinds-rs
 **THIS CRATE IS WORK IN PROGRESS YET. The first beta release is planned as 0.1.0. Until then, this
 library can be buggy and have arbitrary breaking changes.**
 
-[keybinds-rs][crates-io] is a small Rust crate to define/parse/dispatch key bindings.
+[keybinds-rs][crates-io] is a small Rust crate to define/parse/dispatch key bindings (keyboard shortcuts).
 
 - Provide the syntax to easily define key bindings in a configuration file like `Ctrl+a`. ([document](./doc/binding_syntax.md))
 - Support key sequences like `Ctrl+x Ctrl+s` for complicated key bindings like Vim style.

README.md

@@ -1,6 +1,6 @@
 //! # Overview
 //!
-//! [keybinds-rs][crates-io] is a small Rust crate to define/parse/dispatch key bindings.
+//! [keybinds-rs][crates-io] is a small Rust crate to define/parse/dispatch key bindings (keyboard shortcuts).
 //!
 //! - Provide a syntax to easily define key bindings in a configuration file like `Ctrl+a`
 //! - Support key sequences like `Ctrl+x Ctrl+s` for complicated key bindings like Vim style

src/lib.rs

@@ -131,7 +131,7 @@ mod tests {
     }
 
     #[test]
-    fn deserialize_key_binds() {
+    fn deserialize_key_bindings_ok() {
         let input = r#"
         [bindings]
         "j" = "Action1"
@@ -163,16 +163,35 @@ mod tests {
         assert_eq!(actual.deref(), &expected);
     }
 
+    #[test]
+    fn deserialize_empty_table() {
+        let _: Keybinds<A> = toml::from_str("").unwrap();
+    }
+
+    #[test]
+    fn deserialize_key_bindings_error() {
+        let tests = [
+            r#""x" = 12"#,
+            r#""x" = "Action123456""#,
+            r#""" = "Action1""#,
+            r#""     " = "Action1""#,
+            r#""Foooo" = "Action1""#,
+            r#""Foooo+x" = "Action1""#,
+            r#""Ctrl+Fooooo" = "Action1""#,
+            r#""Shift+a" = "Action1""#, // Error because it violates invariant
+        ];
+
+        for input in tests {
+            let _ = toml::from_str::<Keybinds<A>>(input)
+                .expect_err(&format!("invalid input {input:?}"));
+        }
+    }
+
     #[test]
     fn deserialize_mod_key_bind() {
         let input = r#""Mod+x" = "Action1""#;
         let actual: Keybinds<A> = toml::from_str(input).unwrap();
-        let expected = [
-            #[cfg(target_os = "macos")]
-            Keybind::new(KeyInput::new('x', Mods::CMD), A::Action1),
-            #[cfg(not(target_os = "macos"))]
-            Keybind::new(KeyInput::new('x', Mods::CTRL), A::Action1),
-        ];
+        let expected = [Keybind::new(KeyInput::new('x', Mods::MOD), A::Action1)];
         assert_eq!(actual.deref(), expected);
     }
 }