treewide: Add no_retry test tag

We tag all proptests with this tag, because we don't want to mark the
build as passed if we retry and don't generate the same failing test
case.

Change-Id: If79652402e6a144ed2cea9d46e4462fa8798b232
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/9562
Reviewed-by: Johnathan Davis <[email protected]>
Tested-by: Buildkite CI

Author: mvzink

.config/nextest.toml

@@ -25,3 +25,7 @@ test-group = 'serial-postgres'
 [[profile.default.overrides]]
 filter = 'test(/:serial:/) and test(/:mysql\d*_upstream:/)'
 test-group = 'serial-mysql'
+
+[[profile.default.overrides]]
+filter = 'test(/:proptest:/)'
+retries = 0

Cargo.lock

@@ -33,7 +33,7 @@ async fn mysql_connection() -> mysql_async::Conn {
     .unwrap()
 }
 
-#[tags(serial, mysql_upstream)]
+#[tags(serial, no_retry, mysql_upstream)]
 #[proptest]
 #[slow]
 fn value_of_type_always_valid(
@@ -61,7 +61,7 @@ fn value_of_type_always_valid(
     .unwrap();
 }
 
-#[tags(serial, mysql_upstream)]
+#[tags(serial, no_retry, mysql_upstream)]
 #[proptest]
 #[slow]
 fn unique_value_of_type_always_valid(
@@ -92,7 +92,7 @@ fn unique_value_of_type_always_valid(
     .unwrap();
 }
 
-#[tags(serial, mysql_upstream)]
+#[tags(serial, no_retry, mysql_upstream)]
 #[proptest]
 #[slow]
 fn random_value_of_type_always_valid(

data-generator/tests/mysql.rs

@@ -1481,6 +1481,7 @@ mod tests {
         arbitrary_timestamp_naive_date_time, arbitrary_timestamp_naive_date_time_for_timezone,
     };
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use super::*;
     use crate::eval::tests::{eval_expr, try_eval_expr};
@@ -2064,6 +2065,7 @@ mod tests {
     // NOTE(Fran): We have to be careful when testing timezones, as the time difference
     //   between two timezones might differ depending on the date (due to daylight savings
     //   or by historical changes).
+    #[tags(no_retry)]
     #[proptest]
     fn convert_tz(
         #[strategy(arbitrary_timestamp_naive_date_time_for_timezone(Atlantic::Cape_Verde))]
@@ -2076,24 +2078,26 @@ mod tests {
             .unwrap()
             .with_timezone(&target_tz)
             .naive_local();
-        assert_eq!(
+        self::assert_eq!(
             super::convert_tz(&datetime, &src_tz.to_string(), &target_tz.to_string()).unwrap(),
             expected
         );
         super::convert_tz(&datetime, "invalid timezone", &target_tz.to_string()).unwrap_err();
         super::convert_tz(&datetime, &src_tz.to_string(), "invalid timezone").unwrap_err();
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn day_of_week(#[strategy(arbitrary_timestamp_naive_date_time())] datetime: NaiveDateTime) {
         let expected = datetime.weekday().number_from_sunday() as u8;
-        assert_eq!(super::day_of_week(&datetime.date()), expected);
+        self::assert_eq!(super::day_of_week(&datetime.date()), expected);
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn month(#[strategy(arbitrary_timestamp_naive_date_time())] datetime: NaiveDateTime) {
         let expected = datetime.month() as u8;
-        assert_eq!(super::month(&datetime.date()), expected);
+        self::assert_eq!(super::month(&datetime.date()), expected);
     }
 
     #[test]

dataflow-expression/src/eval/builtins.rs

@@ -727,6 +727,8 @@ mod tests {
     use itertools::Itertools;
     use proptest::prelude::*;
 
+    use test_utils::tags;
+
     use super::*;
 
     mod json_quote {
@@ -735,6 +737,7 @@ mod tests {
 
         use super::*;
 
+        #[tags(no_retry)]
         #[proptest]
         fn inputs(string: String) {
             let quoted = json_quote(&string);
@@ -747,6 +750,7 @@ mod tests {
             assert_eq!(json_quote("wo\u{1f}rl\\d"), r#""wo\u001frl\\d""#);
         }
 
+        #[tags(no_retry)]
         #[proptest]
         fn non_escaped(s: String) {
             let contains_escapable = s
@@ -755,7 +759,7 @@ mod tests {
 
             prop_assume!(!contains_escapable);
 
-            assert_eq!(json_quote(&s), format!("\"{s}\""));
+            self::assert_eq!(json_quote(&s), format!("\"{s}\""));
         }
 
         #[test]

dataflow-expression/src/eval/json.rs

@@ -119,6 +119,7 @@ impl From<String> for LikePattern {
 #[cfg(test)]
 mod tests {
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use super::*;
 
@@ -165,6 +166,7 @@ mod tests {
         assert!(LikePattern::new(r"\\", CaseSensitive).matches(r"\"));
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn pattern_matches_itself(pat: String) {
         lazy_static! {

dataflow-expression/src/like.rs

@@ -219,14 +219,16 @@ mod tests {
 
     mod insert_bidirectional {
         use pretty_assertions::assert_eq;
+        use test_utils::tags;
 
         use super::*;
 
+        #[tags(no_retry)]
         #[proptest]
         fn inputs(mut vec: Vec<u32>, index: isize, element: u32, insert_after: bool) {
             let prev_len = vec.len();
             insert_bidirectional(&mut vec, index, element, insert_after);
-            assert_eq!(vec.len(), prev_len + 1);
+            self::assert_eq!(vec.len(), prev_len + 1);
         }
 
         #[track_caller]

dataflow-expression/src/utils.rs

@@ -51,6 +51,7 @@ rust_decimal = { workspace = true, features = [
     "db-tokio-postgres",
     "serde-str",
 ] }
+test-utils = { path = "../test-utils" }
 
 [[bench]]
 name = "persistent_state"

dataflow-state/Cargo.toml

@@ -313,6 +313,7 @@ impl RangeKey {
 mod tests {
     use readyset_data::Collation;
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use super::*;
 
@@ -369,6 +370,7 @@ mod tests {
         );
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn single_point_key_serialize_injective(v1: DfValue, v2: DfValue) {
         let k1 = PointKey::Single(v1);

dataflow-state/src/key.rs

@@ -2504,6 +2504,7 @@ mod tests {
     use replication_offset::postgres::PostgresPosition;
     use rust_decimal::Decimal;
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use super::*;
 
@@ -2539,6 +2540,7 @@ mod tests {
         state
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn point_key_serialize_round_trip(key: PointKey) {
         let serialized = PersistentState::serialize_prefix(&key);
@@ -2547,7 +2549,7 @@ mod tests {
         where
             D: DeserializeOwned + Debug + PartialEq,
         {
-            assert_eq!(deserialize_key::<D>(serialized).1, v);
+            self::assert_eq!(deserialize_key::<D>(serialized).1, v);
         }
 
         match key {

dataflow-state/src/persistent_state/mod.rs

@@ -9,8 +9,9 @@ description = "An efficient non-overlapping interval tree that merges overlappin
 [dependencies]
 
 [dev-dependencies]
-test-strategy = { workspace = true }
 proptest = { workspace = true }
+test-strategy = { workspace = true }
+test-utils = { path = "../test-utils" }
 
 [lints]
 workspace = true

merging-interval-tree/Cargo.toml

@@ -1002,6 +1002,7 @@ mod tests {
     use std::ops::{Bound, RangeBounds};
 
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use crate::{Endpoint, IntervalTreeSet};
 
@@ -1457,6 +1458,7 @@ mod tests {
             .is_none());
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn insert_interval_is_in_tree(intervals: Vec<(Bound<u16>, Bound<u16>)>) {
         let mut tree = IntervalTreeSet::default();
@@ -1491,6 +1493,7 @@ mod tests {
         }
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn remove_interval_not_in_tree(intervals: Vec<(Bound<u16>, Bound<u16>)>) {
         let mut tree = IntervalTreeSet::<u16>::default();

merging-interval-tree/src/lib.rs

@@ -16,6 +16,7 @@ mysql_common = { workspace = true }
 
 [dev-dependencies]
 test-strategy = { workspace = true }
+test-utils = { path = "../test-utils" }
 
 [lints]
 workspace = true

mysql-time/Cargo.toml

@@ -676,6 +676,7 @@ mod tests {
         arbitrary_duration, arbitrary_naive_date_time, arbitrary_naive_time,
     };
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use super::*;
 
@@ -704,6 +705,7 @@ mod tests {
         };
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn new(#[strategy(arbitrary_duration())] duration: Duration) {
         let mysql_time = MySqlTime::new(duration);
@@ -725,6 +727,7 @@ mod tests {
         assert_valid!(mysql_time, -MAX_MYSQL_TIME_SECONDS);
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn from_microseconds(#[strategy(arbitrary_duration())] duration: Duration) {
         let mysql_time =
@@ -785,6 +788,7 @@ mod tests {
         assert!(mysql_time1 < mysql_time3)
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn sub(
         #[strategy(arbitrary_duration())] duration1: Duration,
@@ -796,6 +800,7 @@ mod tests {
         assert_valid!(mysql_time1 - mysql_time2, total_secs);
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn add(
         #[strategy(arbitrary_duration())] duration1: Duration,
@@ -807,6 +812,7 @@ mod tests {
         assert_valid!(mysql_time1 + mysql_time2, total_secs);
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn add_naive_date_time(
         #[strategy(arbitrary_duration())] duration: Duration,
@@ -820,6 +826,7 @@ mod tests {
     mod from_str {
         use super::*;
 
+        #[tags(no_retry)]
         #[proptest]
         fn from_str(#[strategy(arbitrary_duration())] duration: Duration) {
             let duration_str = duration_to_str(duration);
@@ -828,6 +835,7 @@ mod tests {
             assert_valid!(mysql_time, total_secs);
         }
 
+        #[tags(no_retry)]
         #[proptest]
         fn from_str_display(#[strategy(arbitrary_duration())] duration: Duration) {
             let mysql_time = MySqlTime::new(duration);
@@ -1259,6 +1267,7 @@ mod tests {
         }
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn naive_time_from_into_round_trip(#[strategy(arbitrary_naive_time())] naive_time: NaiveTime) {
         let mt = MySqlTime::from(naive_time);

mysql-time/src/lib.rs

@@ -712,6 +712,7 @@ mod tests {
     use super::*;
 
     use readyset_sql::DialectDisplay;
+    use test_utils::tags;
 
     use crate::to_nom_result;
 

nom-sql/src/common.rs

@@ -860,6 +860,7 @@ pub(crate) fn expression(
 mod tests {
     use readyset_sql::DialectDisplay;
     use test_strategy::proptest;
+    use test_utils::tags;
 
     use super::*;
     use crate::to_nom_result;
@@ -892,6 +893,7 @@ mod tests {
         )
     }
 
+    #[tags(no_retry)]
     #[proptest]
     fn arbitrary_expr_doesnt_stack_overflow(_expr: Expr) {}