readyset-sql: Implement conversion of sqlparser ROW syntax

This was missing but tested by a readyset-sql-passes test which hadn't
been converted away from nom-sql (fixed in a forthcoming patch).

Change-Id: I6a6a6964854c7d3c647552b315f75b8989240e61
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/9665
Reviewed-by: Mohamed Yasser Abdelhamed Abdeen <[email protected]>
Tested-by: Buildkite CI

Author: mvzink

readyset-sql-parsing/tests/parity.rs

@@ -524,3 +524,8 @@ fn test_create_table_with_data_directory_option() {
         DEFAULT CHARSET=utf8mb4;"#
     );
 }
+
+#[test]
+fn test_row() {
+    check_parse_both!(r#"SELECT ROW(1, 2, 3);"#);
+}

readyset-sql/src/ast/expression.rs

@@ -1339,27 +1339,34 @@ impl TryFromDialect<sqlparser::ast::Function> for Expr {
                 expr: next_expr()?,
                 distinct,
             })
-        } else if ident.value.eq_ignore_ascii_case("GROUP_CONCAT") {
-            Self::Call(FunctionExpr::GroupConcat {
-                expr: next_expr()?,
-                separator,
-            })
-        } else if ident.value.eq_ignore_ascii_case("MAX") {
-            Self::Call(FunctionExpr::Max(next_expr()?))
-        } else if ident.value.eq_ignore_ascii_case("MIN") {
-            Self::Call(FunctionExpr::Min(next_expr()?))
-        } else if ident.value.eq_ignore_ascii_case("SUM") {
-            Self::Call(FunctionExpr::Sum {
-                expr: next_expr()?,
-                distinct,
-            })
         } else if ident.value.eq_ignore_ascii_case("DATE") {
             // TODO: Arguably, this should be in a SQL rewrite pass to preserve input when rendering
             Self::Cast {
                 expr: next_expr()?,
                 ty: crate::ast::SqlType::Date,
                 postgres_style: false,
             }
+        } else if ident.value.eq_ignore_ascii_case("EXTRACT") {
+            return failed!("{ident} should have been converted earlier");
+        } else if ident.value.eq_ignore_ascii_case("GROUP_CONCAT") {
+            Self::Call(FunctionExpr::GroupConcat {
+                expr: next_expr()?,
+                separator,
+            })
+        } else if ident.value.eq_ignore_ascii_case("JSON_OBJECT_AGG") {
+            Self::Call(FunctionExpr::JsonObjectAgg {
+                key: next_expr()?,
+                value: next_expr()?,
+                allow_duplicate_keys: true,
+            })
+        } else if ident.value.eq_ignore_ascii_case("JSONB_OBJECT_AGG")
+            || ident.value.eq_ignore_ascii_case("JSON_OBJECTAGG")
+        {
+            Self::Call(FunctionExpr::JsonObjectAgg {
+                key: next_expr()?,
+                value: next_expr()?,
+                allow_duplicate_keys: false,
+            })
         } else if ident.value.eq_ignore_ascii_case("LOWER") {
             let expr = next_expr()?;
             match *expr {
@@ -1372,6 +1379,20 @@ impl TryFromDialect<sqlparser::ast::Function> for Expr {
                     collation: None,
                 }),
             }
+        } else if ident.value.eq_ignore_ascii_case("MAX") {
+            Self::Call(FunctionExpr::Max(next_expr()?))
+        } else if ident.value.eq_ignore_ascii_case("MIN") {
+            Self::Call(FunctionExpr::Min(next_expr()?))
+        } else if ident.value.eq_ignore_ascii_case("ROW") {
+            Self::Row {
+                explicit: true,
+                exprs: exprs.try_collect()?,
+            }
+        } else if ident.value.eq_ignore_ascii_case("SUM") {
+            Self::Call(FunctionExpr::Sum {
+                expr: next_expr()?,
+                distinct,
+            })
         } else if ident.value.eq_ignore_ascii_case("UPPER") {
             let expr = next_expr()?;
             match *expr {
@@ -1384,22 +1405,6 @@ impl TryFromDialect<sqlparser::ast::Function> for Expr {
                     collation: None,
                 }),
             }
-        } else if ident.value.eq_ignore_ascii_case("JSON_OBJECT_AGG") {
-            Self::Call(FunctionExpr::JsonObjectAgg {
-                key: next_expr()?,
-                value: next_expr()?,
-                allow_duplicate_keys: true,
-            })
-        } else if ident.value.eq_ignore_ascii_case("JSONB_OBJECT_AGG")
-            || ident.value.eq_ignore_ascii_case("JSON_OBJECTAGG")
-        {
-            Self::Call(FunctionExpr::JsonObjectAgg {
-                key: next_expr()?,
-                value: next_expr()?,
-                allow_duplicate_keys: false,
-            })
-        } else if ident.value.eq_ignore_ascii_case("EXTRACT") {
-            return failed!("{ident} should have been converted earlier");
         } else {
             ident.value = ident.value.to_lowercase();
             Self::Call(FunctionExpr::Call {