Skip to content

DID 0xF188 double #269

Closed
Closed
@KingKeule

Description

@KingKeule

Some lines of code are duplicated.

Source: https://github.com/pylessard/python-udsoncan/blob/master/udsoncan/common/dids.py

LOC 31: VehicleManufacturerECUSoftwareNumber = 0xF188
LOC 32: VehicleManufacturerECUSoftwareNumber = 0xF188

and

LOC 90: if did == 0xF188:
LOC 91: return 'VehicleManufacturerECUSoftwareNumberDataIdentifier'
LOC 92: if did == 0xF188:
LOC 93: return 'VehicleManufacturerECUSoftwareNumberDataIdentifier'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions