error when used with postgresql 12 devel version.

[digoal]

error when used with postgresql 12 devel version.

root@iZbp13nu0s9j3x3op4zpd4Z-> USE_PGXS=1 make clean
rm -f rum.so   librum.a  librum.pc
rm -f src/rumsort.o src/rum_ts_utils.o src/rumtsquery.o src/rumbtree.o src/rumbulk.o src/rumdatapage.o src/rumentrypage.o src/rumget.o src/ruminsert.o src/rumscan.o src/rumutil.o src/rumvacuum.o src/rumvalidate.o src/btree_rum.o src/rum_arr_utils.o  src/rumsort.bc src/rum_ts_utils.bc src/rumtsquery.bc src/rumbtree.bc src/rumbulk.bc src/rumdatapage.bc src/rumentrypage.bc src/rumget.bc src/ruminsert.bc src/rumscan.bc src/rumutil.bc src/rumvacuum.bc src/rumvalidate.bc src/btree_rum.bc src/rum_arr_utils.bc
rm -rf results/ regression.diffs regression.out tmp_check/ tmp_check_iso/ log/ output_iso/
root@iZbp13nu0s9j3x3op4zpd4Z-> git checkout stable
Branch stable set up to track remote branch stable from origin.
Switched to a new branch 'stable'
root@iZbp13nu0s9j3x3op4zpd4Z-> USE_PGXS=1 make 
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumsort.o src/rumsort.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rum_ts_utils.o src/rum_ts_utils.c
In file included from /home/digoal/pgsql12/include/server/access/skey.h:19:0,
                 from /home/digoal/pgsql12/include/server/access/genam.h:18,
                 from /home/digoal/pgsql12/include/server/access/amapi.h:15,
                 from /home/digoal/pgsql12/include/server/access/hash.h:20,
                 from src/rum_ts_utils.c:14:
src/rum_ts_utils.c: In function ‘rum_tsquery_distance’:
src/rum_ts_utils.c:1427:20: warning: implicit declaration of function ‘get_float8_infinity’ [-Wimplicit-function-declaration]
   PG_RETURN_FLOAT8(get_float8_infinity());
                    ^
/home/digoal/pgsql12/include/server/fmgr.h:331:52: note: in definition of macro ‘PG_RETURN_FLOAT8’
 #define PG_RETURN_FLOAT8(x)  return Float8GetDatum(x)
                                                    ^
src/rum_ts_utils.c: In function ‘rum_ts_distance_tt’:
src/rum_ts_utils.c:1447:20: warning: implicit declaration of function ‘get_float4_infinity’ [-Wimplicit-function-declaration]
   PG_RETURN_FLOAT4(get_float4_infinity());
                    ^
/home/digoal/pgsql12/include/server/fmgr.h:330:52: note: in definition of macro ‘PG_RETURN_FLOAT4’
 #define PG_RETURN_FLOAT4(x)  return Float4GetDatum(x)
                                                    ^
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumtsquery.o src/rumtsquery.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumbtree.o src/rumbtree.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumbulk.o src/rumbulk.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumdatapage.o src/rumdatapage.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumentrypage.o src/rumentrypage.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumget.o src/rumget.c
src/rumget.c: In function ‘keyGetOrdering’:
src/rumget.c:2175:11: warning: implicit declaration of function ‘get_float8_infinity’ [-Wimplicit-function-declaration]
    return get_float8_infinity();
           ^~~~~~~~~~~~~~~~~~~
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/ruminsert.o src/ruminsert.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumscan.o src/rumscan.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumutil.o src/rumutil.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumvacuum.o src/rumvacuum.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rumvalidate.o src/rumvalidate.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/btree_rum.o src/btree_rum.c
src/btree_rum.c: In function ‘rum_int2_distance’:
src/btree_rum.c:262:11: warning: implicit declaration of function ‘get_float8_infinity’ [-Wimplicit-function-declaration]
    diff = get_float8_infinity();         \
           ^
src/btree_rum.c:407:1: note: in expansion of macro ‘RUM_SUPPORT_DIST’
 RUM_SUPPORT_DIST(int2, false, leftmostvalue_int2, btint2cmp, always_false, int2subtract)
 ^~~~~~~~~~~~~~~~
src/btree_rum.c: In function ‘leftmostvalue_float4’:
src/btree_rum.c:440:25: warning: implicit declaration of function ‘get_float4_infinity’ [-Wimplicit-function-declaration]
  return Float4GetDatum(-get_float4_infinity());
                         ^~~~~~~~~~~~~~~~~~~
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -I. -I./ -I/home/digoal/pgsql12/include/server -I/home/digoal/pgsql12/include/internal  -D_GNU_SOURCE   -c -o src/rum_arr_utils.o src/rum_arr_utils.c
In file included from /home/digoal/pgsql12/include/server/access/skey.h:19:0,
                 from /home/digoal/pgsql12/include/server/access/genam.h:18,
                 from /home/digoal/pgsql12/include/server/access/amapi.h:15,
                 from /home/digoal/pgsql12/include/server/access/hash.h:20,
                 from src/rum_arr_utils.c:14:
src/rum_arr_utils.c: In function ‘rum_anyarray_ordering’:
src/rum_arr_utils.c:73:19: warning: implicit declaration of function ‘get_float8_infinity’; did you mean ‘get_attidentity’? [-Wimplicit-function-declaration]
  ( (sml == 0.0) ? get_float8_infinity() : ((float8) 1) / ((float8) (sml)) )
                   ^
/home/digoal/pgsql12/include/server/fmgr.h:331:52: note: in definition of macro ‘PG_RETURN_FLOAT8’
 #define PG_RETURN_FLOAT8(x)  return Float8GetDatum(x)
                                                    ^
src/rum_arr_utils.c:457:20: note: in expansion of macro ‘DIST_FROM_SML’
   PG_RETURN_FLOAT8(DIST_FROM_SML(sml));
                    ^~~~~~~~~~~~~
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O3 -fPIC -shared -o rum.so src/rumsort.o src/rum_ts_utils.o src/rumtsquery.o src/rumbtree.o src/rumbulk.o src/rumdatapage.o src/rumentrypage.o src/rumget.o src/ruminsert.o src/rumscan.o src/rumutil.o src/rumvacuum.o src/rumvalidate.o src/btree_rum.o src/rum_arr_utils.o  -L/home/digoal/pgsql12/lib    -Wl,--as-needed -Wl,-rpath,'/home/digoal/pgsql12/lib',--enable-new-dtags -lm  
root@iZbp13nu0s9j3x3op4zpd4Z-> USE_PGXS=1 make install
/bin/mkdir -p '/home/digoal/pgsql12/lib'
/bin/mkdir -p '/home/digoal/pgsql12/share/extension'
/bin/mkdir -p '/home/digoal/pgsql12/share/extension'
/bin/install -c -m 755  rum.so '/home/digoal/pgsql12/lib/rum.so'
/bin/install -c -d '/home/digoal/pgsql12/include/server/'
/bin/install -c -m 644 .//src/rum.h .//src/rumsort.h '/home/digoal/pgsql12/include/server/'
/bin/install -c -m 644 .//rum.control '/home/digoal/pgsql12/share/extension/'
/bin/install -c -m 644 .//rum--1.0.sql .//rum--1.2.sql .//rum--1.0--1.1.sql .//rum--1.1--1.2.sql  '/home/digoal/pgsql12/share/extension/'
root@iZbp13nu0s9j3x3op4zpd4Z-> psql
psql (12devel)
Type "help" for help.

postgres=# create extension rum;
ERROR:  could not load library "/home/digoal/pgsql12/lib/rum.so": /home/digoal/pgsql12/lib/rum.so: undefined symbol: get_float4_infinity

thank you
best regards.

[za-arthur]

Thank you for the report! Fixed.

[andreak]

I'm still getting this with a fresh checkout e34375

[za-arthur]

Hi,
On what version of Postgres do you see it? Unfortunately I cannot reproduce it. I tested on PostgreSQL 12 Beta 4 and on master branch.

[andreak]

12beta4 commit dc92bf5cad7ccae294ec7055382c7727726702cc

[za-arthur]

Unfortunately I didn't reproduce on dc92bf5cad7ccae294ec7055382c7727726702cc either.
Did you run make distclean on source before building?

[andreak]

I always run distclean before building:

make distclean && ./configure --prefix=$HOME/programs/postgresql-master --with-openssl && make -j 8 install-world-contrib-recurse install-world-doc-recurse

But I'm unable to "make clean" in rum:

make clean
Makefile:43: /contrib/contrib-global.mk: No such file or directory
make: *** No rule to make target '/contrib/contrib-global.mk'.  Stop.

So deleting my rum-dir, re-cloning + build + install made the problem go away.

[za-arthur]

I can see this message:

Makefile:43: /contrib/contrib-global.mk: No such file or directory

only when I don't use USE_PGXS=1 option. You need to use it or just copy rum source directory to PostgreSQL's contrib directory.

[andreak]

Aha, that's causing it then - thanks for clarifying.

[za-arthur]

Yeah, it can find necessary makefiles only if you use USE_PGXS=1 option or when it is inside contrib directory.