Fix zero payload size cause panic

tyohan · Sean-Der · commit 0eab1887cec7 · 2024-10-06T22:36:07.000-04:00
diff --git a/pkg/nack/retainable_packet.go b/pkg/nack/retainable_packet.go
@@ -78,7 +78,7 @@ func (m *packetManager) NewPacket(header *rtp.Header, payload []byte, rtxSsrc ui
 
 		// Remove padding if present.
 		paddingLength := 0
-		if p.header.Padding {
+		if p.header.Padding && p.payload != nil && len(p.payload) > 0 {
 			paddingLength = int(p.payload[len(p.payload)-1])
 			p.header.Padding = false
 		}

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ func (m packetManager) NewPacket(header rtp.Header, payload []byte, rtxSsrc ui`
`78`	`78`
`79`	`79`	`// Remove padding if present.`
`80`	`80`	`paddingLength := 0`
`81`		`- if p.header.Padding {`
	`81`	`+ if p.header.Padding && p.payload != nil && len(p.payload) > 0 {`
`82`	`82`	`paddingLength = int(p.payload[len(p.payload)-1])`
`83`	`83`	`p.header.Padding = false`
`84`	`84`	`}`