Skip to content

Commit 6d9f6cd

Browse files
authored
Fix minimum OS version setup (#14)
Make sure to export the MIN_IOS_SDK and MIN_OSX_SDK variables from the makefile as they are needed in "scripts/update-specs.sh" to properly fill in the minimum version requirements in generated CocoaPods spec. Otherwise we only pass them to the OpenSSL build scripts and end up with the spec requesting more broad minimum versions than the range actually supported by the binaries. Instead of exporting the variables to specific script invocations, just make sure that Make exports them to all tools that it launches. That way it's harder to forget to add them for some script.
1 parent d21e3b7 commit 6d9f6cd

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,11 @@ VERSION ?= 1.1.1g
1515

1616
## Extra version of the distributed package
1717
PACKAGE_VERSION ?= 1
18+
export PACKAGE_VERSION
1819

1920
MIN_IOS_SDK = 10.0
2021
MIN_OSX_SDK = 10.11
22+
export MIN_IOS_SDK MIN_OSX_SDK
2123

2224
BUILD_ARCHS += ios_i386 ios_x86_64 ios_arm64 ios_arm64e ios_armv7s ios_armv7
2325
BUILD_ARCHS += mac_x86_64
@@ -94,7 +96,7 @@ endif
9496
.PHONY: packages
9597

9698
$(OUTPUT)/done.packages: $(OUTPUT)/done.build
97-
@PACKAGE_VERSION=$(PACKAGE_VERSION) scripts/create-packages.sh
99+
@scripts/create-packages.sh
98100
@mkdir -p $(OUTPUT)
99101
@touch $(OUTPUT)/done.packages
100102

0 commit comments

Comments
 (0)