refactor!: removed secp256k1 JWS support

Author: panva

README.md

@@ -142,7 +142,6 @@ Please note that certain algorithms may not be available depending on the runtim
 - JSON Web Key Thumbprint URI - [RFC9278](https://www.rfc-editor.org/rfc/rfc9278)
 - JWS Unencoded Payload Option - [RFC7797](https://www.rfc-editor.org/rfc/rfc7797)
 - CFRG Elliptic Curve ECDH and Signatures - [RFC8037](https://www.rfc-editor.org/rfc/rfc8037)
-- secp256k1 EC Key curve support - [RFC8812](https://www.rfc-editor.org/rfc/rfc8812)
 
 The algorithm implementations in `jose` have been tested using test vectors from their respective specifications as well as [RFC7520](https://www.rfc-editor.org/rfc/rfc7520).
 

package.json

@@ -39,7 +39,6 @@
     "pem",
     "pkcs8",
     "rsa",
-    "secp256k1",
     "sign",
     "signature",
     "spki",

src/jwks/local.ts

@@ -107,9 +107,6 @@ class LocalJWKSet<KeyLikeType extends KeyLike = KeyLike> {
           case 'ES256':
             candidate = jwk.crv === 'P-256'
             break
-          case 'ES256K':
-            candidate = jwk.crv === 'secp256k1'
-            break
           case 'ES384':
             candidate = jwk.crv === 'P-384'
             break

src/runtime/node/dsa_digest.ts

@@ -5,7 +5,6 @@ export default function dsaDigest(alg: string) {
     case 'PS256':
     case 'RS256':
     case 'ES256':
-    case 'ES256K':
       return 'sha256'
 
     case 'PS384':

src/runtime/node/generate.ts

@@ -64,8 +64,6 @@ export async function generateKeyPair(alg: string, options?: GenerateKeyPairOpti
     }
     case 'ES256':
       return generate('ec', { namedCurve: 'P-256' })
-    case 'ES256K':
-      return generate('ec', { namedCurve: 'secp256k1' })
     case 'ES384':
       return generate('ec', { namedCurve: 'P-384' })
     case 'ES512':

src/runtime/node/get_named_curve.ts

@@ -16,8 +16,6 @@ const namedCurveToJOSE = (namedCurve: string) => {
       return 'P-384'
     case 'secp521r1':
       return 'P-521'
-    case 'secp256k1':
-      return 'secp256k1'
     default:
       throw new JOSENotSupported('Unsupported key curve for this operation')
   }

src/runtime/node/node_key.ts

@@ -8,7 +8,6 @@ import type { JWK } from '../../types.d'
 
 const ecCurveAlgMap = new Map([
   ['ES256', 'P-256'],
-  ['ES256K', 'secp256k1'],
   ['ES384', 'P-384'],
   ['ES512', 'P-521'],
 ])
@@ -106,7 +105,6 @@ export default function keyForCrypto<KeyObjectOptions, JWKOptions>(
       }
       break
     case 'ES256':
-    case 'ES256K':
     case 'ES384':
     case 'ES512': {
       if (asymmetricKeyType !== 'ec') {

tap/ecdh.ts

@@ -14,7 +14,6 @@ export default (QUnit: QUnit, lib: typeof jose, keys: typeof jose) => {
     ['ECDH-ES', true],
     ['ECDH-ES', true, { crv: 'P-384' }],
     ['ECDH-ES', !env.isDeno, { crv: 'P-521' }],
-    ['ECDH-ES', false, { crv: 'secp256k1' }],
     [
       'ECDH-ES',
       env.isNode ||

tap/fixtures.ts

@@ -262,33 +262,4 @@ export const KEYS = {
       '-----END PUBLIC KEY-----\n',
     x509: undefined,
   },
-  secp256k1: {
-    jwk: {
-      crv: 'secp256k1',
-      d: '4FnXRICPA8cKwNZhg1XvGS3cyWXzuJ17imMFjlgn42w',
-      kty: 'EC',
-      x: 'hwxzC9RSkkBmbBche2iTjNCLbB7XG6h5lfHmOXTQDmQ',
-      y: 'xzddq8Sa9Gn6EOCeYghU6uyWQoh1mWAHx0p6Zd0N9Bo',
-    },
-    pkcs8:
-      '-----BEGIN PRIVATE KEY-----\n' +
-      'MIGEAgEAMBAGByqGSM49AgEGBSuBBAAKBG0wawIBAQQg4FnXRICPA8cKwNZhg1Xv\n' +
-      'GS3cyWXzuJ17imMFjlgn42yhRANCAASHDHML1FKSQGZsFyF7aJOM0ItsHtcbqHmV\n' +
-      '8eY5dNAOZMc3XavEmvRp+hDgnmIIVOrslkKIdZlgB8dKemXdDfQa\n' +
-      '-----END PRIVATE KEY-----\n',
-    spki:
-      '-----BEGIN PUBLIC KEY-----\n' +
-      'MFYwEAYHKoZIzj0CAQYFK4EEAAoDQgAEhwxzC9RSkkBmbBche2iTjNCLbB7XG6h5\n' +
-      'lfHmOXTQDmTHN12rxJr0afoQ4J5iCFTq7JZCiHWZYAfHSnpl3Q30Gg==\n' +
-      '-----END PUBLIC KEY-----\n',
-    x509:
-      '-----BEGIN CERTIFICATE-----\n' +
-      'MIIBBTCBrQIJAMqeTnxEXkWqMAoGCCqGSM49BAMCMA0xCzAJBgNVBAYTAkNaMB4X\n' +
-      'DTIyMTAxMTEyMjUxNFoXDTIzMTAwNjEyMjUxNFowDTELMAkGA1UEBhMCQ1owVjAQ\n' +
-      'BgcqhkjOPQIBBgUrgQQACgNCAASHDHML1FKSQGZsFyF7aJOM0ItsHtcbqHmV8eY5\n' +
-      'dNAOZMc3XavEmvRp+hDgnmIIVOrslkKIdZlgB8dKemXdDfQaMAoGCCqGSM49BAMC\n' +
-      'A0cAMEQCICLsIR+59yZbMsxvtYMH+Lmlko0/ihPHU/vbpfc7XXa1AiALT04GYkMx\n' +
-      '/xy0TNunfynvxfMAX+9x+3tO8g/KbPZp7w==\n' +
-      '-----END CERTIFICATE-----\n',
-  },
 }

tap/jwk.ts

@@ -29,7 +29,6 @@ export default (QUnit: QUnit, lib: typeof jose, keys: typeof jose) => {
     ['Ed25519', KEYS.Ed25519.jwk, !env.isBlink],
     ['EdDSA', KEYS.Ed448.jwk, env.isNode || env.isEdgeRuntime],
     ['ES256', KEYS.P256.jwk, true],
-    ['ES256K', KEYS.secp256k1.jwk, lib.cryptoRuntime === 'node:crypto' && !env.isElectron],
     ['ES384', KEYS.P384.jwk, true],
     ['ES512', KEYS.P521.jwk, env.isDeno ? [true, false] : true],
     ['PS256', KEYS.RSA.jwk, true],

tap/jws.ts

@@ -13,12 +13,6 @@ export default (QUnit: QUnit, lib: typeof jose, keys: typeof jose) => {
     ['Ed25519', !env.isBlink],
     ['EdDSA', env.isNode || env.isEdgeRuntime, { crv: 'Ed448' }],
     ['ES256', true],
-    [
-      'ES256K',
-      lib.cryptoRuntime === 'node:crypto' &&
-        keys.cryptoRuntime === 'node:crypto' &&
-        !env.isElectron,
-    ],
     ['ES384', true],
     ['ES512', !env.isDeno],
     ['PS256', true],

tap/pem.ts

@@ -16,9 +16,6 @@ export default (QUnit: QUnit, lib: typeof jose, keys: typeof jose) => {
     ['ES256', KEYS.P256.pkcs8, true],
     ['ES256', KEYS.P256.spki, true],
     ['ES256', KEYS.P256.x509, true],
-    ['ES256K', KEYS.secp256k1.pkcs8, lib.cryptoRuntime === 'node:crypto' && !env.isElectron],
-    ['ES256K', KEYS.secp256k1.spki, lib.cryptoRuntime === 'node:crypto' && !env.isElectron],
-    ['ES256K', KEYS.secp256k1.x509, lib.cryptoRuntime === 'node:crypto' && !env.isElectron],
     ['ES384', KEYS.P384.pkcs8, true],
     ['ES384', KEYS.P384.spki, true],
     ['ES384', KEYS.P384.x509, true],

test/jws/restrictions.test.mjs

@@ -121,5 +121,3 @@ test(testRSAenc, 'RSA-OAEP-512')
 test(testECDSASigEncoding, 'ES256')
 test(testECDSASigEncoding, 'ES384')
 test(testECDSASigEncoding, 'ES512')
-
-test(testECDSASigEncoding, 'ES256K')