Skip to content

Expired Login/Consent Challenge Should be Resolvable for Consent App #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 of 5 tasks
terev opened this issue May 28, 2024 · 1 comment · May be fixed by #3802
Open
4 of 5 tasks

Expired Login/Consent Challenge Should be Resolvable for Consent App #3772

terev opened this issue May 28, 2024 · 1 comment · May be fixed by #3802
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@terev
Copy link
Contributor

terev commented May 28, 2024 •
edited
Loading

Preflight checklist

Ory Network Project

No response

Describe your problem

When a login or consent challenge expires Hydra returns a HTTP 401 with an error indicating the expiry. However this makes it hard for the consent app to resolve the error state. This issue will mostly arise when the user has requested a login form which embeds the login challenge, and they leave the form open until the challenge has expired. This is hard for the consent app to resolve as it can no longer view the login request at this point.

Describe your ideal solution

Ideally Hydra would return a HTTP 410 and include where the consent app should redirect to in order to resolve this error state. Like how hydra responds for handled challenges. #2057 (comment)

Workarounds or alternatives

Was able to somewhat work around this by extracting the request url and return it as a hidden field in the login form. Then on login form submission I match the expired challenge errors, and redirect to the request url to restart the flow.

Version

2.2.0

Additional Context

No response
@terev terev added the feat New feature or request. label May 28, 2024
@terev terev linked a pull request Jul 21, 2024 that will close this issue
Open
7 tasks
@github-actions GitHub Actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: for expired challenges return HTTP 410 and redirect url terev/hydra
1 participant
@terev