[BUG] Index being replaced when changes on Aliases

[TGcandeias]

What is the bug?

When updating, adding or removing a alias to an existing Index, terraform will replace the index, instead of performing an update in place.

How can one reproduce the bug?

1. Create a index with 1 or more aliases using opensearch_index.index

resource "opensearch_index" "index" {
  name = "terraform-index"
  aliases = jsonencode(
    {
      log = {
        is_write_index = true
      }
    }
  )
  number_of_replicas = "0"
  number_of_shards   = "1"
  mappings = file("../.opensearch/testmapping.json")
}

2. After it has been created update the definition and execute a new plan:

What is the expected behavior?

It is expected for the index to be updated in place instead of being recreated.

What is your host/environment?

Terraform v1.10.3
on windows_amd64

• provider registry.terraform.io/opensearch-project/opensearch v2.3.1

Do you have any screenshots?

Do you have any additional context?

This was discussed in a previous issue(#85 (comment)), reported fixed on v2.3.1 but till manifests

[prudhvigodithi]

[Triage]
From my past tests #85 (comment) I see the index alias is updated (some more tests in PR https://github.com/opensearch-project/terraform-provider-opensearch/pull/212/files), I could be wrong but can you try mappings = file without file example and see if you are still seeing the same behavior. Also did are you trying to just update the index or alias details ?

 mappings = jsonencode({
    "properties": {
      "age": {
        "type": "integer"
      }
    }
  })

One more route is can you test with

1. Create with

 aliases = jsonencode(
    {
      log = {
        is_write_index = true
      }
    }
  )

2. Remove the aliases.
3. Now create with

 aliases = jsonencode(
    {
      log3 = {
        is_write_index = true
      }
    }
  )

@getsaurabh02 @rblcoder

[TGcandeias]

Hi,

Thank you for your reply.

Going over the suggested approach.

Step1
Creating index with 1 alias:

resource "opensearch_index" "index" {
  name = "terraform-index"
  aliases = jsonencode(
    {
      log = {
        is_write_index = true
      }
    }
  )
  number_of_replicas = "0"
  number_of_shards   = "1"
  mappings = jsonencode({
    "properties": {
      "age": {
        "type": "integer"
      }
    }
  })
}

---

Step2 - Remove alias

resource "opensearch_index" "index" {
  name = "terraform-index"
  number_of_replicas = "0"
  number_of_shards   = "1"
  mappings = jsonencode({
    "properties": {
      "age": {
        "type": "integer"
      }
    }
  })
}

Also performing a direct change on the alias works. The issue seems to be directly related with using a json file to manage the mappings, even when it does not change.

It seems that the culprit is indeed using the file method to provide a json file.

[jclavoie22]

We can reproduce the same issue here. No index change yet the provider wants to replace the index. This seems to have started after upgrading from OS 2.15 to 2.19.