Skip to content

Remove thread.name from metrics #14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove ThreadGrouper as well, since it is now unused
See: [#14047](#14047)
  • Loading branch information
jhayes2-chwy committed Jun 19, 2025
commit 960e1024f3256cd486fd20975bc70e0ea988d1bf
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@
import io.opentelemetry.api.metrics.MeterBuilder;
import io.opentelemetry.instrumentation.api.internal.EmbeddedInstrumentationProperties;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.RecordedEventHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.ThreadGrouper;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.buffer.DirectBufferStatisticsHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.classes.ClassesLoadedHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.container.ContainerConfigurationHandler;
@@ -84,17 +83,16 @@ static List<RecordedEventHandler> getHandlers(
}
}

ThreadGrouper grouper = new ThreadGrouper();
List<RecordedEventHandler> basicHandlers =
List.of(
new ObjectAllocationInNewTlabHandler(meter, grouper),
new ObjectAllocationOutsideTlabHandler(meter, grouper),
new NetworkReadHandler(meter, grouper),
new NetworkWriteHandler(meter, grouper),
new ObjectAllocationInNewTlabHandler(meter),
new ObjectAllocationOutsideTlabHandler(meter),
new NetworkReadHandler(meter),
new NetworkWriteHandler(meter),
new ContextSwitchRateHandler(meter),
new OverallCpuLoadHandler(meter),
new ContainerConfigurationHandler(meter),
new LongLockHandler(meter, grouper),
new LongLockHandler(meter),
new ThreadCountHandler(meter),
new ClassesLoadedHandler(meter),
new MetaspaceSummaryHandler(meter),

This file was deleted.

Original file line number Diff line number Diff line change
@@ -12,7 +12,6 @@
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.Constants;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.DurationUtil;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.RecordedEventHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.ThreadGrouper;
import java.time.Duration;
import java.util.Optional;
import jdk.jfr.consumer.RecordedEvent;
@@ -31,7 +30,7 @@ public final class LongLockHandler implements RecordedEventHandler {
private final DoubleHistogram histogram;
private final Attributes attributes;

public LongLockHandler(Meter meter, ThreadGrouper grouper) {
public LongLockHandler(Meter meter) {
super();
histogram =
meter
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@
import io.opentelemetry.instrumentation.runtimemetrics.java17.JfrFeature;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.Constants;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.RecordedEventHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.ThreadGrouper;
import jdk.jfr.consumer.RecordedEvent;

/**
@@ -28,7 +27,7 @@ public final class ObjectAllocationInNewTlabHandler implements RecordedEventHand
private final LongHistogram histogram;
private final Attributes attributes;

public ObjectAllocationInNewTlabHandler(Meter meter, ThreadGrouper grouper) {
public ObjectAllocationInNewTlabHandler(Meter meter) {
super();
histogram =
meter
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@
import io.opentelemetry.instrumentation.runtimemetrics.java17.JfrFeature;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.Constants;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.RecordedEventHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.ThreadGrouper;
import jdk.jfr.consumer.RecordedEvent;

/**
@@ -28,7 +27,7 @@ public final class ObjectAllocationOutsideTlabHandler implements RecordedEventHa
private final LongHistogram histogram;
private final Attributes attributes;

public ObjectAllocationOutsideTlabHandler(Meter meter, ThreadGrouper grouper) {
public ObjectAllocationOutsideTlabHandler(Meter meter) {
super();
histogram =
meter
Original file line number Diff line number Diff line change
@@ -13,7 +13,6 @@
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.Constants;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.DurationUtil;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.RecordedEventHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.ThreadGrouper;
import jdk.jfr.consumer.RecordedEvent;

/**
@@ -28,7 +27,7 @@ public final class NetworkReadHandler implements RecordedEventHandler {
private final DoubleHistogram durationHistogram;
private final Attributes attributes;

public NetworkReadHandler(Meter meter, ThreadGrouper nameNormalizer) {
public NetworkReadHandler(Meter meter) {
super();
bytesHistogram =
meter
Original file line number Diff line number Diff line change
@@ -13,7 +13,6 @@
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.Constants;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.DurationUtil;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.RecordedEventHandler;
import io.opentelemetry.instrumentation.runtimemetrics.java17.internal.ThreadGrouper;
import jdk.jfr.consumer.RecordedEvent;

// jdk.SocketWrite {
@@ -46,7 +45,7 @@ public final class NetworkWriteHandler implements RecordedEventHandler {
private final DoubleHistogram durationHistogram;
private final Attributes attributes;

public NetworkWriteHandler(Meter meter, ThreadGrouper nameNormalizer) {
public NetworkWriteHandler(Meter meter) {
super();
bytesHistogram =
meter