Skip to content

More runtime metrics for Spring starter with GraalVM #13245

Open
@zeitlinger

Description

@zeitlinger

Feature

Spring starter with GraalVM currently (when #13173 is merged) doesn't support

GraalVM 23

PR: #13269

Once JFR metrics work: the current setup only tests the latest LTS version of GraalVM.

Graal 23 has a different options for enabling JFR - which has been tried out in #13078 - this line: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13078/files#diff-75989ca3659128c1bc6aea21d1129a7a704b98959fad35345d5c3c216c53c91cR71

It may turn out that JFR metrics are only possible with Graal 23, which would mean that we have test 23.
If 21 also supports JFR metrics, we still want to test 23 - to know that our JFR metrics will not break in the
future.

Cleanup

Runtime metrics are currently configured in RuntimeMetricsAutoConfiguration class.

#13236 is a PR with a cleaner separation
of runtime metrics into different @Configuration classes.
It turned out that the RuntimeMetricsBeanRegistrationExcludeFilter can't exclude @Configuration classes, so
we discarded that approach. => solved by excluding the bean contained un the autoconfiguration

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestneeds triageNew issue that requires triage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions