Bump errorProneVersion from 2.18.0 to 2.19.0 (#8459)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <[email protected]>

Author: dependabot[bot]

conventions/src/main/kotlin/otel.errorprone-conventions.gradle.kts

@@ -123,6 +123,10 @@ tasks {
           // Allow underscore in test-type method names
           disable("MemberName")
         }
+        if (project.path.endsWith(":testing") || name.contains("Test")) {
+          // This check causes too many failures, ignore the ones in tests
+          disable("CanIgnoreReturnValueSuggester")
+        }
       }
     }
   }

dependencyManagement/build.gradle.kts

@@ -42,7 +42,7 @@ val DEPENDENCY_BOMS = listOf(
 
 val autoServiceVersion = "1.0.1"
 val autoValueVersion = "1.10.1"
-val errorProneVersion = "2.18.0"
+val errorProneVersion = "2.19.0"
 val byteBuddyVersion = "1.14.4"
 val asmVersion = "9.5"
 val jmhVersion = "1.36"

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/ForwardedHeaderParser.java

@@ -5,14 +5,15 @@
 
 package io.opentelemetry.instrumentation.api.instrumenter.http;
 
+import java.util.Locale;
 import javax.annotation.Nullable;
 
 final class ForwardedHeaderParser {
 
   /** Extract proto (aka scheme) from "Forwarded" http header. */
   @Nullable
   static String extractProtoFromForwardedHeader(String forwarded) {
-    int start = forwarded.toLowerCase().indexOf("proto=");
+    int start = forwarded.toLowerCase(Locale.ROOT).indexOf("proto=");
     if (start < 0) {
       return null;
     }
@@ -32,7 +33,7 @@ static String extractProtoFromForwardedProtoHeader(String forwardedProto) {
   /** Extract client IP address from "Forwarded" http header. */
   @Nullable
   static String extractClientIpFromForwardedHeader(String forwarded) {
-    int start = forwarded.toLowerCase().indexOf("for=");
+    int start = forwarded.toLowerCase(Locale.ROOT).indexOf("for=");
     if (start < 0) {
       return null;
     }

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/SpanSuppressors.java

@@ -5,6 +5,7 @@
 
 package io.opentelemetry.instrumentation.api.instrumenter;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.context.Context;
@@ -20,6 +21,7 @@ enum Noop implements SpanSuppressor {
     INSTANCE;
 
     @Override
+    @CanIgnoreReturnValue
     public Context storeInContext(Context context, SpanKind spanKind, Span span) {
       return context;
     }

instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/TracingRequestHandler.java

@@ -10,6 +10,7 @@
 import com.amazonaws.Response;
 import com.amazonaws.handlers.HandlerContextKey;
 import com.amazonaws.handlers.RequestHandler2;
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.context.Context;
 import io.opentelemetry.contrib.awsxray.propagator.AwsXrayPropagator;
 import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
@@ -47,6 +48,7 @@ public void beforeRequest(Request<?> request) {
   }
 
   @Override
+  @CanIgnoreReturnValue
   public AmazonWebServiceRequest beforeMarshalling(AmazonWebServiceRequest request) {
     if (SqsReceiveMessageRequestAccess.isInstance(request)) {
       if (!SqsReceiveMessageRequestAccess.getAttributeNames(request)

instrumentation/hibernate/hibernate-6.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v6_0/SessionTest.java

@@ -18,6 +18,7 @@
 import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Locale;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.BiConsumer;
 import java.util.function.Function;
@@ -838,7 +839,7 @@ private static SpanDataAssert assertClientSpan(
             equalTo(SemanticAttributes.DB_CONNECTION_STRING, "h2:mem:"),
             satisfies(
                 SemanticAttributes.DB_STATEMENT,
-                stringAssert -> stringAssert.startsWith(verb.toLowerCase())),
+                stringAssert -> stringAssert.startsWith(verb.toLowerCase(Locale.ROOT))),
             equalTo(SemanticAttributes.DB_OPERATION, verb),
             equalTo(SemanticAttributes.DB_SQL_TABLE, "Value"));
   }

instrumentation/internal/internal-lambda/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/lambda/InnerClassLambdaMetafactoryInstrumentation.java

@@ -7,6 +7,7 @@
 
 import static net.bytebuddy.matcher.ElementMatchers.named;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import net.bytebuddy.asm.AsmVisitorWrapper;
@@ -42,6 +43,7 @@ public int mergeWriter(int flags) {
                   }
 
                   @Override
+                  @CanIgnoreReturnValue
                   public int mergeReader(int flags) {
                     return flags;
                   }

instrumentation/internal/internal-reflection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/reflection/ClassInstrumentation.java

@@ -7,6 +7,7 @@
 
 import static net.bytebuddy.matcher.ElementMatchers.named;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import net.bytebuddy.asm.AsmVisitorWrapper;
@@ -41,6 +42,7 @@ public int mergeWriter(int flags) {
                   }
 
                   @Override
+                  @CanIgnoreReturnValue
                   public int mergeReader(int flags) {
                     return flags;
                   }

instrumentation/jaxrs/jaxrs-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/CompletionStageFinishCallback.java

@@ -5,6 +5,7 @@
 
 package io.opentelemetry.javaagent.instrumentation.jaxrs;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.context.Context;
 import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
 import java.util.function.BiFunction;
@@ -22,6 +23,7 @@ public CompletionStageFinishCallback(
   }
 
   @Override
+  @CanIgnoreReturnValue
   public T apply(T result, Throwable throwable) {
     instrumenter.end(context, handlerData, null, throwable);
     return result;

instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

@@ -9,6 +9,7 @@
 import static java.util.logging.Level.FINE;
 import static java.util.regex.Pattern.CASE_INSENSITIVE;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.instrumentation.jdbc.internal.dbinfo.DbInfo;
 import io.opentelemetry.semconv.trace.attributes.SemanticAttributes.DbSystemValues;
 import java.io.UnsupportedEncodingException;
@@ -36,6 +37,7 @@
 public enum JdbcConnectionUrlParser {
   GENERIC_URL_LIKE() {
     @Override
+    @CanIgnoreReturnValue
     DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
       try {
         // Attempt generic parsing
@@ -78,6 +80,7 @@ DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
   // see http://jtds.sourceforge.net/faq.html#urlFormat
   JTDS_URL_LIKE() {
     @Override
+    @CanIgnoreReturnValue
     DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
       String serverName = "";
 
@@ -150,6 +153,7 @@ DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
             CASE_INSENSITIVE);
 
     @Override
+    @CanIgnoreReturnValue
     DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
       String serverName = "";
       Integer port = null;
@@ -361,6 +365,7 @@ DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
     private final Pattern userPattern = Pattern.compile("\\(\\s*user\\s*=\\s*([^ )]+)\\s*\\)");
 
     @Override
+    @CanIgnoreReturnValue
     DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
       int addressEnd = jdbcUrl.indexOf(",address=");
       if (addressEnd > 0) {
@@ -527,6 +532,7 @@ DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
 
   ORACLE_AT() {
     @Override
+    @CanIgnoreReturnValue
     DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
       if (jdbcUrl.contains("@(description")) {
         return ORACLE_AT_DESCRIPTION.doParse(jdbcUrl, builder);
@@ -569,6 +575,7 @@ DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
         Pattern.compile("\\(\\s*service_name\\s*=\\s*([^ )]+)\\s*\\)");
 
     @Override
+    @CanIgnoreReturnValue
     DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) {
       String[] atSplit = jdbcUrl.split("@", 2);