Merge pull request #39 from im-ryan/chore/full-test-coverage

chore: 100% test coverage

Author: nunomaduro

src/Commands/EssentialsPintCommand.php

@@ -5,6 +5,7 @@
 namespace NunoMaduro\Essentials\Commands;
 
 use Illuminate\Console\Command;
+use Illuminate\Support\Facades\File;
 
 final class EssentialsPintCommand extends Command
 {
@@ -36,20 +37,20 @@ public function handle(): int
         $stub_path = __DIR__.'/../../stubs/pint.stub';
         $destination_path = base_path('pint.json');
 
-        if (! file_exists($stub_path)) {
+        if (! File::exists($stub_path)) {
             $this->components->error('Pint configuration stub file not found.');
 
             return 1;
         }
 
-        if (file_exists($destination_path) && $this->option('backup')) {
-            copy($destination_path, $destination_path.'.backup');
+        if (File::exists($destination_path) && $this->option('backup')) {
+            File::copy($destination_path, $destination_path.'.backup');
             $this->components->info('Backup created at: '.$destination_path.'.backup');
         }
 
         $this->components->info('Publishing Pint configuration file...');
 
-        if (! copy($stub_path, $destination_path)) {
+        if (! File::copy($stub_path, $destination_path)) {
             $this->components->error('Failed to publish the Pint configuration file.');
 
             return 1;

src/Commands/EssentialsRectorCommand.php

@@ -5,6 +5,7 @@
 namespace NunoMaduro\Essentials\Commands;
 
 use Illuminate\Console\Command;
+use Illuminate\Support\Facades\File;
 
 final class EssentialsRectorCommand extends Command
 {
@@ -36,20 +37,20 @@ public function handle(): int
         $stub_path = __DIR__.'/../../stubs/rector.stub';
         $destination_path = base_path('rector.php');
 
-        if (! file_exists($stub_path)) {
+        if (! File::exists($stub_path)) {
             $this->components->error('Rector configuration stub file not found.');
 
             return 1;
         }
 
-        if (file_exists($destination_path) && $this->option('backup')) {
-            copy($destination_path, $destination_path.'.backup');
+        if (File::exists($destination_path) && $this->option('backup')) {
+            File::copy($destination_path, $destination_path.'.backup');
             $this->components->info('Backup created at: '.$destination_path.'.backup');
         }
 
         $this->components->info('Publishing Rector configuration file...');
 
-        if (! copy($stub_path, $destination_path)) {
+        if (! File::copy($stub_path, $destination_path)) {
             $this->components->error('Failed to publish the Rector configuration file.');
 
             return 1;

tests/Commands/EssentialsPintCommandTest.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Illuminate\Support\Facades\File;
-use NunoMaduro\Essentials\Commands\EssentialsPintCommand;
 
 beforeEach(function (): void {
     // Clean up any existing pint.json files
@@ -16,13 +15,33 @@
     }
 });
 
-it('publishes pint configuration file', function (): void {
-    $command = new EssentialsPintCommand;
-
+it('publishes pint configuration file without a backup by default', function (): void {
     $this->artisan('essentials:pint', ['--force' => true])
         ->assertExitCode(0);
 
     expect(file_exists(base_path('pint.json')))->toBeTrue();
+    expect(file_exists(base_path('pint.json.backup')))->toBeFalse();
+});
+
+it('returns error when pint configuration file does not exist', function (): void {
+    // The stub file should not exist
+    File::shouldReceive('exists')
+        ->once()
+        ->andReturnFalse();
+
+    $this->artisan('essentials:pint', ['--force' => true])
+        ->assertExitCode(1);
+});
+
+it('returns error when copy operation fails', function (): void {
+    // The file should exist but not be copyable
+    File::shouldReceive('exists')->andReturnTrue();
+    File::shouldReceive('copy')
+        ->once()
+        ->andReturnFalse();
+
+    $this->artisan('essentials:pint', ['--force' => true])
+        ->assertExitCode(1);
 });
 
 it('creates a backup when requested', function (): void {
@@ -47,6 +66,19 @@
     expect(file_get_contents(base_path('pint.json')))->toBe('{"test": "original"}');
 });
 
+it('publishes pint configuration file when user confirms', function (): void {
+    // Create a dummy pint.json file first
+    File::put(base_path('pint.json'), '{"test": "original"}');
+
+    $this->artisan('essentials:pint')
+        ->expectsConfirmation('Do you wish to publish the Pint configuration file? This will override the existing [pint.json] file.', 'yes')
+        ->assertExitCode(0);
+
+    expect(file_exists(base_path('pint.json')))
+        ->not()
+        ->toBe('{"test": "original"}');
+});
+
 afterEach(function (): void {
     // Clean up any created files
     if (file_exists(base_path('pint.json'))) {

tests/Commands/EssentialsRectorCommandTest.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Illuminate\Support\Facades\File;
-use NunoMaduro\Essentials\Commands\EssentialsRectorCommand;
 
 beforeEach(function (): void {
     if (file_exists(base_path('rector.php'))) {
@@ -15,13 +14,32 @@
     }
 });
 
-it('publishes rector configuration file', function (): void {
-    $command = new EssentialsRectorCommand();
-
+it('publishes rector configuration file without a backup by default', function (): void {
     $this->artisan('essentials:rector', ['--force' => true])
         ->assertExitCode(0);
 
     expect(file_exists(base_path('rector.php')))->toBeTrue();
+    expect(file_exists(base_path('rector.json.backup')))->toBeFalse();
+});
+
+it('returns error when rector configuration file does not exist', function (): void {
+    File::shouldReceive('exists')
+        ->once()
+        ->andReturnFalse();
+
+    $this->artisan('essentials:rector', ['--force' => true])
+        ->expectsOutputToContain('Rector configuration stub file not found.')
+        ->assertExitCode(1);
+});
+
+it('returns error when copy operation fails', function (): void {
+    File::shouldReceive('exists')->andReturnTrue();
+    File::shouldReceive('copy')
+        ->once()
+        ->andReturnFalse();
+
+    $this->artisan('essentials:rector', ['--force' => true])
+        ->assertExitCode(1);
 });
 
 it('creates a backup when requested', function (): void {
@@ -43,6 +61,18 @@
     expect(file_get_contents(base_path('rector.php')))->toBe('<?php return [];');
 });
 
+it('publishes rector configuration file when user confirms', function (): void {
+    File::put(base_path('rector.php'), '<?php return [];');
+
+    $this->artisan('essentials:rector')
+        ->expectsConfirmation('Do you wish to publish the Rector configuration file? This will override the existing [rector.php] file.', 'yes')
+        ->assertExitCode(0);
+
+    expect(file_get_contents(base_path('rector.php')))
+        ->not()
+        ->toBe('<?php return [];');
+});
+
 afterEach(function (): void {
     if (file_exists(base_path('rector.php'))) {
         unlink(base_path('rector.php'));