fix: resolve memory leaks in long-running VSCode sessions #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several memory leak issues that accumulate during long-running VSCode sessions: 1. **Language Model Cache Interval Management**: Fixed potential interval accumulation by properly clearing existing intervals before creating new ones 2. **MCP Server Keep-Alive Intervals**: Added tracking of all active intervals and comprehensive cleanup in stopMcpServer() to prevent orphaned intervals 3. **Workspace Refresh Timeout Accumulation**: Prevented setTimeout accumulation in refreshWorkspaceWithBackoff by tracking and clearing existing timeouts, plus added 10-second timeout limits to prevent infinite waits 4. **Project Path Cache Unbounded Growth**: Added 5-minute cache expiration to prevent indefinite growth of _rootProjectMap cache These fixes should significantly reduce memory usage in Activity Monitor when running VSCode for extended periods (days) without restart. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
View your CI Pipeline Execution ↗ for commit 63a1acf
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several memory leak issues that accumulate during long-running VSCode sessions, addressing the high memory usage seen in Activity Monitor when VSCode runs for days without restart.
Changes Made