fix(intellij): use transformed generator schema to match VSCode filte… #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit d7debab.
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/intellij/src/main/kotlin/dev/nx/console/nxls/NxlsService.kt
Outdated
Show resolved
Hide resolved
|
@claude the current implementations diverge, as far as I can tell. In the vscode implementation, we make the options request and then we make a followup nxls request. Do the same in the intellij implementation. Also adopt the graphite review comment |
|
Claude finished @MaxKless's task —— View job ✅ Changes Complete
Changes Made
Both IntelliJ implementations now match VSCode's approach: Commit: 2bc0619 Note: Please run |
…ring - Add NxTransformedGeneratorSchemaRequest support to IntelliJ - Update NxGenerateService to use transformed schema instead of raw options - Update NxGenerateRunAnythingProvider to use transformed schema - Both IDEs now show identical filtered generator options - Internal/deprecated options (buildable, compiler) are consistently filtered out - Add regression test to verify schema transformation behavior Fixes #2517 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: MaxKless <[email protected]>
- Implement two-step pattern: getGeneratorOptions() then getTransformedGeneratorSchema() - Restore fallback behavior in transformedGeneratorSchema() as suggested by review - Both IntelliJ implementations now match VSCode's approach for consistent filtering Co-authored-by: MaxKless <[email protected]>
MaxKless
force-pushed
the
claude/issue-2517-20250531_110746
branch
from
2bc0619 to
3319de8
Compare
MaxKless
force-pushed
the
claude/issue-2517-20250531_110746
branch
from
60bae06 to
d7debab
Compare
Coly010
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both editors now use the proper transformed generator schema to power the UI
Fixes #2517
🤖 Generated with Claude Code