fix(vscode): remove affected condition from onboarding checks (#2583)

Author: MaxKless

apps/nxls-e2e/src/nx-cloud/nx-cloud-onboarding-info-default.test.ts

@@ -44,7 +44,6 @@ describe('nx cloud onboarding - default', () => {
     });
     expect(onboardingInfoResponse.result).toMatchInlineSnapshot(`
       Object {
-        "hasAffectedCommandsInCI": false,
         "hasNxInCI": false,
         "isConnectedToCloud": false,
         "isWorkspaceClaimed": false,
@@ -120,7 +119,6 @@ describe('nx cloud onboarding - default', () => {
 
     const info = onboardingInfoResponse.result as CloudOnboardingInfo;
 
-    expect(info.hasAffectedCommandsInCI).toEqual(true);
     expect(info.hasNxInCI).toEqual(true);
   });
 });

libs/language-server/workspace/src/lib/get-cloud-onboarding-info.ts

@@ -19,14 +19,10 @@ export async function getCloudOnboardingInfo(
   const hasNxInCI = commonCIFileContents.some((content) =>
     content.includes('nx '),
   );
-  const hasAffectedCommandsInCI = commonCIFileContents.some((content) =>
-    content.includes('nx affected'),
-  );
 
   if (!(await isNxCloudUsed(workspacePath))) {
     return {
       hasNxInCI,
-      hasAffectedCommandsInCI,
       isConnectedToCloud: false,
       isWorkspaceClaimed: false,
       personalAccessToken: undefined,
@@ -52,7 +48,6 @@ export async function getCloudOnboardingInfo(
 
   return {
     hasNxInCI,
-    hasAffectedCommandsInCI,
     isConnectedToCloud,
     isWorkspaceClaimed,
     personalAccessToken,

libs/shared/types/src/lib/cloud-info.ts

@@ -1,6 +1,5 @@
 export type CloudOnboardingInfo = {
   hasNxInCI: boolean;
-  hasAffectedCommandsInCI: boolean;
   isConnectedToCloud: boolean;
   isWorkspaceClaimed: boolean;
   personalAccessToken: string | undefined;

libs/vscode/nx-cloud-onboarding-webview/src/main.ts

@@ -21,11 +21,11 @@ export class Root extends LitElement {
       <div style="font-size: var(--vscode-font-size)">
         ${completed.map(
           (text) =>
-            html`<list-entry .text=${text} .completed=${true}></list-entry>`
+            html`<list-entry .text=${text} .completed=${true}></list-entry>`,
         )}
         ${notCompleted.map(
           (text) =>
-            html`<list-entry .text=${text} .completed=${false}></list-entry>`
+            html`<list-entry .text=${text} .completed=${false}></list-entry>`,
         )}
       </div>
 
@@ -51,14 +51,9 @@ export class Root extends LitElement {
     const notCompleted: string[] = [];
 
     (this.cloudOnboardingInfo?.hasNxInCI ? completed : notCompleted).push(
-      'Use Nx in your CI configuration'
+      'Use Nx in your CI configuration',
     );
 
-    (this.cloudOnboardingInfo?.hasAffectedCommandsInCI
-      ? completed
-      : notCompleted
-    ).push('Use affected commands in your CI configuration');
-
     (this.cloudOnboardingInfo?.isConnectedToCloud
       ? completed
       : notCompleted
@@ -88,8 +83,6 @@ export class Root extends LitElement {
       return 'Finish Nx Cloud Setup';
     } else if (!this.cloudOnboardingInfo.hasNxInCI) {
       return 'Generate CI configuration';
-    } else if (!this.cloudOnboardingInfo.hasAffectedCommandsInCI) {
-      return 'Learn about affected commands';
     } else {
       return 'Open Nx Cloud App';
     }
@@ -119,14 +112,6 @@ export class Root extends LitElement {
           >Learn more about Nx Cloud</vscode-link
         >
       </p>`;
-    } else if (!this.cloudOnboardingInfo.hasAffectedCommandsInCI) {
-      return html`<p>
-        Affected commands are a powerful feature of Nx and allow you to skip any
-        unnecessary computation in your CI pipeline.
-        <vscode-link href="https://nx.dev/ci/intro/why-nx-cloud"
-          >Learn more about Nx Cloud</vscode-link
-        >
-      </p>`;
     } else {
       return html``;
     }
@@ -141,8 +126,6 @@ export class Root extends LitElement {
       });
     } else if (!this.cloudOnboardingInfo.hasNxInCI) {
       this.vscodeApi.postMessage({ type: 'generate-ci' });
-    } else if (!this.cloudOnboardingInfo.hasAffectedCommandsInCI) {
-      this.vscodeApi.postMessage({ type: 'show-affected-docs' });
     } else {
       this.vscodeApi.postMessage({ type: 'open-cloud-app' });
     }

libs/vscode/nx-cloud-view/src/cloud-onboarding-view.ts

@@ -55,8 +55,8 @@ export class CloudOnboardingViewProvider implements WebviewViewProvider {
 
   async resolveWebviewView(
     webviewView: WebviewView,
-    context: WebviewViewResolveContext,
-    token: CancellationToken,
+    _context: WebviewViewResolveContext,
+    _token: CancellationToken,
   ): Promise<void> {
     this.ensureStateSubscription();
 
@@ -113,14 +113,6 @@ export class CloudOnboardingViewProvider implements WebviewViewProvider {
         generateCI();
         break;
       }
-      case 'show-affected-docs': {
-        getTelemetry().logUsage('cloud.show-affected-docs');
-        commands.executeCommand(
-          'vscode.open',
-          Uri.parse('https://nx.dev/ci/features/affected?utm_source=nxconsole'),
-        );
-        break;
-      }
       case 'open-cloud-app': {
         commands.executeCommand('nxCloud.openApp');
         break;

libs/vscode/nx-cloud-view/src/cloud-view-state-machine.spec.ts

@@ -91,7 +91,6 @@ describe('Cloud View State Machine', () => {
       type: 'UPDATE_ONBOARDING',
       value: {
         hasNxInCI: true,
-        hasAffectedCommandsInCI: true,
         isConnectedToCloud: false,
         isWorkspaceClaimed: false,
         personalAccessToken: undefined,
@@ -111,7 +110,6 @@ describe('Cloud View State Machine', () => {
       type: 'UPDATE_ONBOARDING',
       value: {
         hasNxInCI: true,
-        hasAffectedCommandsInCI: true,
         isConnectedToCloud: true,
         isWorkspaceClaimed: true,
         personalAccessToken: undefined,
@@ -148,7 +146,6 @@ describe('Cloud View State Machine', () => {
       type: 'UPDATE_ONBOARDING',
       value: {
         hasNxInCI: true,
-        hasAffectedCommandsInCI: true,
         isConnectedToCloud: true,
         isWorkspaceClaimed: false,
         personalAccessToken: undefined,

libs/vscode/nx-cloud-view/src/cloud-view-state-machine.ts

@@ -160,19 +160,13 @@ export const machine = setup({
         type: 'setErrorContext',
       } as any);
     }),
-    compareCIPEDataAndSendNotification: (
-      _,
-      params: {
-        oldData: CIPEInfo[];
-        newData: CIPEInfo[];
-      },
-    ) => {
+    compareCIPEDataAndSendNotification: () => {
       throw new Error('Not implemented');
     },
-    setViewVisible: (_, params: { viewId: string }) => {
+    setViewVisible: () => {
       throw new Error('Not implemented');
     },
-    setErrorContext: ({ context }) => {
+    setErrorContext: () => {
       throw new Error('Not implemented');
     },
     requestRecentCIPEData: emit({
@@ -193,8 +187,7 @@ export const machine = setup({
       return Boolean(
         context.onboardingInfo?.isWorkspaceClaimed &&
           context.onboardingInfo?.isConnectedToCloud &&
-          context.onboardingInfo?.hasNxInCI &&
-          context.onboardingInfo?.hasAffectedCommandsInCI,
+          context.onboardingInfo?.hasNxInCI,
       );
     },
     hasOnboardingInfo: ({ context }) => {