Follow task avoidance guidance. (square#8632)

* Follow task avoidance guidance.

https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview

Author: yschimke

build.gradle.kts

@@ -57,7 +57,7 @@ allprojects {
     google()
   }
 
-  tasks.create("downloadDependencies") {
+  tasks.register("downloadDependencies") {
     description = "Download all dependencies to the Gradle cache"
     doLast {
       for (configuration in configurations) {
@@ -96,6 +96,15 @@ subprojects {
   apply(plugin = "biz.aQute.bnd.builder")
   apply(plugin = "io.github.usefulness.maven-sympathy")
 
+  // Skip samples parent
+  if (project.buildFile.exists()) {
+    apply(plugin = "com.android.lint")
+
+    dependencies {
+      "lintChecks"(rootProject.libs.androidx.lint.gradle)
+    }
+  }
+
   tasks.withType<JavaCompile> {
     options.encoding = Charsets.UTF_8.toString()
   }
@@ -266,7 +275,6 @@ subprojects {
   }
 
   plugins.withId("com.vanniktech.maven.publish.base") {
-    val publishingExtension = extensions.getByType(PublishingExtension::class.java)
     configure<MavenPublishBaseExtension> {
       publishToMavenCentral(SonatypeHost.S01, automaticRelease = true)
       signAllPublications()

gradle/libs.versions.toml

@@ -8,6 +8,7 @@ de-mannodermaus-junit5 = "1.6.0"
 graalvm = "24.1.1"
 kotlinx-serialization = "1.7.3"
 ksp = "2.1.0-1.0.29"
+lintGradle = "1.0.0-alpha03"
 mockserverClient = "5.15.0"
 org-bouncycastle = "1.76"
 org-conscrypt = "2.5.2"
@@ -23,6 +24,7 @@ androidx-activity = "androidx.activity:activity-ktx:1.9.3"
 androidx-annotation = "androidx.annotation:annotation:1.9.1"
 androidx-espresso-core = "androidx.test.espresso:espresso-core:3.6.1"
 androidx-junit = "androidx.test.ext:junit:1.2.1"
+androidx-lint-gradle = { module = "androidx.lint:lint-gradle", version.ref = "lintGradle" }
 androidx-test-runner = "androidx.test:runner:1.6.2"
 animalsniffer-annotations = "org.codehaus.mojo:animal-sniffer-annotations:1.24"
 aqute-resolve = { module = "biz.aQute.bnd:biz.aQute.resolve", version.ref = "biz-aQute-bnd" }

okcurl/build.gradle.kts

@@ -1,6 +1,7 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
 import org.graalvm.buildtools.gradle.dsl.GraalVMExtension
+import ru.vyarus.gradle.plugin.animalsniffer.AnimalSnifferExtension
 
 plugins {
   kotlin("jvm")
@@ -39,7 +40,7 @@ dependencies {
   testImplementation(kotlin("test"))
 }
 
-animalsniffer {
+configure<AnimalSnifferExtension> {
   isIgnoreFailures = true
 }
 

okhttp/build.gradle.kts

@@ -1,9 +1,6 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import java.io.DataInputStream
-import java.io.FileInputStream
 import java.util.Base64
-import java.util.zip.GZIPInputStream
 
 plugins {
   kotlin("jvm")
@@ -18,8 +15,10 @@ fun ByteArray.toByteStringExpression(): String {
 }
 
 val copyKotlinTemplates = tasks.register<Copy>("copyKotlinTemplates") {
+  val kotlinTemplatesOutput = layout.buildDirectory.dir("generated/sources/kotlinTemplates")
+
   from("src/main/kotlinTemplates")
-  into(layout.buildDirectory.dir("generated/sources/kotlinTemplates"))
+  into(kotlinTemplatesOutput)
 
   // Tag as an input to regenerate after an update
   inputs.file("src/test/resources/okhttp3/internal/publicsuffix/PublicSuffixDatabase.gz")
@@ -43,18 +42,20 @@ val generateIdnaMappingTableConfiguration: Configuration by configurations.creat
 dependencies {
   generateIdnaMappingTableConfiguration(projects.okhttpIdnaMappingTable)
 }
-val generateIdnaMappingTable by tasks.creating(JavaExec::class.java) {
-  outputs.dir(layout.buildDirectory.dir("generated/sources/idnaMappingTable"))
+val generateIdnaMappingTable = tasks.register<JavaExec>("generateIdnaMappingTable") {
+  val idnaOutput = layout.buildDirectory.dir("generated/sources/idnaMappingTable")
+
+  outputs.dir(idnaOutput)
   mainClass.set("okhttp3.internal.idn.GenerateIdnaMappingTableCode")
-  args(layout.buildDirectory.dir("generated/sources/idnaMappingTable").get())
+  args(idnaOutput.get())
   classpath = generateIdnaMappingTableConfiguration
 }
 
 kotlin {
   sourceSets {
     getByName("main") {
-      kotlin.srcDir(copyKotlinTemplates.get().outputs)
-      kotlin.srcDir(generateIdnaMappingTable.outputs)
+      kotlin.srcDir(copyKotlinTemplates.map { it.outputs })
+      kotlin.srcDir(generateIdnaMappingTable.map { it.outputs })
     }
   }
 }
@@ -107,11 +108,13 @@ normalization {
 // Expose OSGi jars to the test environment.
 val osgiTestDeploy: Configuration by configurations.creating
 
-val copyOsgiTestDeployment by tasks.creating(Copy::class.java) {
+val test by tasks.existing(Test::class)
+val copyOsgiTestDeployment = tasks.register<Copy>("copyOsgiTestDeployment") {
   from(osgiTestDeploy)
   into(layout.buildDirectory.dir("resources/test/okhttp3/osgi/deployments"))
 }
-tasks.getByName("test") {
+
+test.configure {
   dependsOn(copyOsgiTestDeployment)
 }