Avoid inexact read

Author: lahma

Directory.Build.props

@@ -90,7 +90,6 @@
     <NoWarn>$(NoWarn);CA1862</NoWarn> <!-- Prefer the string comparison method overload -->
     <NoWarn>$(NoWarn);CA1872</NoWarn> <!-- Prefer 'System.Convert.ToHexString(byte[])' over call chains based on 'System.BitConverter.ToString(byte[])' -->
     <NoWarn>$(NoWarn);CA2019</NoWarn> <!-- 'ThreadStatic' fields should not use inline initialization -->
-    <NoWarn>$(NoWarn);CA2022</NoWarn> <!-- Avoid inexact read -->
     <NoWarn>$(NoWarn);CA2201</NoWarn> <!-- Exception type System.IndexOutOfRangeException is reserved by the runtime -->
     <NoWarn>$(NoWarn);CA2208</NoWarn> <!-- Method XXX.Remove passes parameter name 'item' as the message argument to a ArgumentNullException constructor. -->
     <NoWarn>$(NoWarn);CA2211</NoWarn> <!-- Non-constant fields should not be visible -->

main/HSSF/Record/OldLabelRecord.cs

@@ -15,6 +15,8 @@ the License.  You may obtain a copy of the License at
    limitations under the License.
 ==================================================================== */
 
+using System.Diagnostics;
+
 namespace NPOI.HSSF.Record
 {
     using System;
@@ -54,7 +56,8 @@ public OldLabelRecord(RecordInputStream in1)
 
             // Can only decode properly later when you know the codepage
             field_5_bytes = new byte[field_4_string_len];
-            in1.Read(field_5_bytes, 0, field_4_string_len);
+            int read = in1.Read(field_5_bytes, 0, field_4_string_len);
+            Debug.Assert(read == field_4_string_len, "Didn't read the right number of bytes");;
 
             if (in1.Remaining > 0)
             {

main/HSSF/Record/OldSheetRecord.cs

@@ -15,6 +15,8 @@ the License.  You may obtain a copy of the License at
    limitations under the License.
 ==================================================================== */
 
+using System.Diagnostics;
+
 namespace NPOI.HSSF.Record
 {
     using System;
@@ -44,7 +46,8 @@ public OldSheetRecord(RecordInputStream in1)
             field_3_type = in1.ReadUByte();
             int field_4_sheetname_length = in1.ReadUByte();
             field_5_sheetname = new byte[field_4_sheetname_length];
-            in1.Read(field_5_sheetname, 0, field_4_sheetname_length);
+            int read = in1.Read(field_5_sheetname, 0, field_4_sheetname_length);
+            Debug.Assert(read == field_4_sheetname_length, "Didn't read the right number of bytes");
         }
 
         public void SetCodePage(CodepageRecord codepage)

main/HSSF/Record/OldStringRecord.cs

@@ -15,6 +15,8 @@ the License.  You may obtain a copy of the License at
    limitations under the License.
 ==================================================================== */
 
+using System.Diagnostics;
+
 namespace NPOI.HSSF.Record
 {
     using System;
@@ -54,7 +56,8 @@ public OldStringRecord(RecordInputStream in1)
 
             // Can only decode properly later when you know the codepage
             field_2_bytes = new byte[field_1_string_len];
-            in1.Read(field_2_bytes, 0, field_1_string_len);
+            int read = in1.Read(field_2_bytes, 0, field_1_string_len);
+            Debug.Assert(read == field_1_string_len, "Didn't read the right number of bytes");
         }
 
         public bool IsBiff2

main/POIFS/NIO/FileBackedDataSource.cs

@@ -53,25 +53,24 @@ public FileBackedDataSource(FileInfo file)
         }
         public FileBackedDataSource(FileInfo file, bool readOnly)
         {
-            if (!file.Exists)
+            if(!file.Exists)
+            {
                 throw new FileNotFoundException(file.FullName);
-            this.fileinfo = file;
-            FileStream stream = new FileStream(file.FullName, FileMode.Open, FileAccess.Read);
-            byte[] temp = new byte[stream.Length];
-            stream.Read(temp, 0, (int)stream.Length);
-            MemoryStream ms = new MemoryStream(temp, 0, temp.Length);
+            }
+            fileinfo = file;
+            using FileStream stream = File.OpenRead(file.FullName);
+            MemoryStream ms = new();
+            stream.CopyTo(ms);
             fileStream = ms;
-            this.writable = !readOnly;
-            stream.Position = 0;
+            writable = !readOnly;
         }
         public FileBackedDataSource(FileStream stream, bool readOnly)
         {
             stream.Position = 0;
-            byte[] temp = new byte[stream.Length];
-            stream.Read(temp, 0, (int)stream.Length);
-            MemoryStream ms = new MemoryStream(temp, 0, temp.Length);
+            MemoryStream ms = new();
+            stream.CopyTo(ms);
             fileStream = ms;
-            this.writable = !readOnly;
+            writable = !readOnly;
             stream.Position = 0;
         }
 
@@ -102,18 +101,9 @@ private void Dispose(bool disposing)
 
         #endregion
 
-        public bool IsWriteable
-        {
-            get
-            {
-                return this.writable;
-            }
-        }
+        public bool IsWriteable => writable;
 
-        public Stream Stream
-        {
-            get { return this.fileStream; }
-        }
+        public Stream Stream => fileStream;
 
         /// <summary>
         /// Reads a sequence of bytes from this FileStream starting at the given file position.

main/Util/CRC32.cs

@@ -104,13 +104,8 @@ public ulong StringCRC(string sInputString)
         /// <returns></returns>
         public long FileCRC(string sInputFilename)
         {
-            using (FileStream inFile = new System.IO.FileStream(sInputFilename, System.IO.FileMode.Open, System.IO.FileAccess.Read))
-            {
-                byte[] bInput = new byte[inFile.Length];
-                inFile.Read(bInput, 0, bInput.Length);
-
-                return (long)ByteCRC(ref bInput);
-            }
+            byte[] bInput = File.ReadAllBytes(sInputFilename);
+            return (long) ByteCRC(ref bInput);
         }
 
         /// <summary>
@@ -120,11 +115,12 @@ public long FileCRC(string sInputFilename)
         /// <returns></returns>
         public long StreamCRC(Stream inFile)
         {
-            byte[] bInput = new byte[inFile.Length];
-            inFile.Read(bInput, 0, bInput.Length);
+            using MemoryStream ms = new();
+            inFile.CopyTo(ms);
             inFile.Close();
 
-            return (long)ByteCRC(ref bInput);
+            byte[] bytes = ms.ToArray();
+            return (long)ByteCRC(ref bytes);
         }
 
         public ulong Value { get; set; }

testcases/ooxml/XSSF/UserModel/TestXSSFName.cs

@@ -150,16 +150,16 @@ public void TestSetNameNameCellAddress()
                     name.NameName = ref1;
                     Assert.Fail("cell addresses are not allowed: " + ref1);
                 }
-                catch (ArgumentException e)
+                catch (ArgumentException)
                 {
                     // expected
                 }
             }
 
             // Name that looks similar to a cell reference but is outside the cell reference row and column limits
-            name.NameName = ("A0");
-            name.NameName = ("F04030020010");
-            name.NameName = ("XFDXFD10");
+            name.NameName = "A0";
+            name.NameName = "F04030020010";
+            name.NameName = "XFDXFD10";
         }
     }
 }