Multiple label values for `-watch-namespace-label` argument

[benshalev849]

At the moment, we have a global "NGINX" namespace, this namespace holds all of our NGINX Ingress Controllers, in addition we have for each client a separate instance.

What we want to achieve is for us to be able to put two labels on our NGINX, one for the client namespace (to catch only their VS etc..) and if a new NS is added, no need for rollout (unlike if we use -watch-namespace)
And one "global" label for our global NGINX ns that holds all the deployments, secrets etc (To watch the default TLS secret and update it automatically when changed)

Describe the solution you'd like
Option to have multiple labels with different values on one ingress controller, for example:
-watch-namespace-label={foo=bar,cert=secret}

Describe alternatives you've considered
An alternative is to put the "unique" label on the main NGINX Namespace, this will cause alot of useless labels and confusion.

[github-actions]

Hi @benshalev849 thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

[vepatel]

Hey @benshalev849 we've controller.watchNamespaceLabel in our helm-chart, see https://docs.nginx.com/nginx-ingress-controller/installation/installing-nic/installation-with-helm/#configuration

For manifest installation: https://docs.nginx.com/nginx-ingress-controller/configuration/global-configuration/command-line-arguments/#-watch-namespace-label-string

[benshalev849]

Hey @benshalev849 we've controller.watchNamespaceLabel in our helm-chart, see https://docs.nginx.com/nginx-ingress-controller/installation/installing-nic/installation-with-helm/#configuration

For manifest installation: https://docs.nginx.com/nginx-ingress-controller/configuration/global-configuration/command-line-arguments/#-watch-namespace-label-string

This is what we are currently using, but sadly we cannot input a list of labels, it only takes one value, for one label.

For example, if i want it to track both foo=bar label and nginx-general=true label i cannot.

[vepatel]

i see what you mean, it'll probably be an additional cli arg as going from string to list will be breaking change

[benshalev849]

i see what you mean, it'll probably be an additional cli arg as going from string to list will be breaking change

Okay, that will also work for us, at the moment when i did 2 CLI args, it only took the second one.

So if i did:

-watch-namespace-label=foo=bar
-watch-namespace-label=nginx-general=true

it only took into effect nginx-general=true

Thank you for your help :)