Skip to content

Gallery layout is triggered when parent element is hidden (width=0) #185

Open
@cvolzke4

Description

@cvolzke4

A re-layout of the photos happens when width is 0, ie. when the containing element is hidden.
This causes the following problems:

  1. For an app with tabs, the scroll position of the gallery is not maintained when changing tabs.
  2. A complete re-layout is performed, which causes images to re-render causing flicker.

Screencast before:
share.getcloudapp.com/2NuybPlb

Screencast with a fix:
share.getcloudapp.com/6quebvrB

Activity

cvolzke4

cvolzke4 commented on Sep 2, 2020

@cvolzke4
Author

Feel free to ping me at cvolzke@google.com if you have any questions.

We'd like to use this in our Story Editor app.

PR: #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @cvolzke4

      Issue actions

        Gallery layout is triggered when parent element is hidden (width=0) · Issue #185 · neptunian/react-photo-gallery