Skip to content

Replace meta.html with a more maintenable / extendable approach #94

Open
@yakky

Description

@yakky
Member

meta.html is quite burdensome to support, as any change to will require people who extended it to adapt.

We will likely need a more robust solution that will allow people to extend it, without the need to change it everytime we add more tags

Activity

self-assigned this
on Aug 7, 2019
lggwettmann

lggwettmann commented on Aug 15, 2019

@lggwettmann

Same issue here. I'm just adding unsupported meta tags manually in the template now cause django-meta doesnt support the Facebook/OpenGraph metatags/microtags for product catalog registration. Would be great if one could just add new tags via the MetaMixin.

yakky

yakky commented on Aug 15, 2019

@yakky
MemberAuthor

@lggwettmann thanks for the feedback. You can also add custom tags via extra_props, extra_custom_props https://django-meta.readthedocs.io/en/latest/views.html#extra-props

lggwettmann

lggwettmann commented on Aug 16, 2019

@lggwettmann

Tried that, but didn't show up in the meta tags.

lggwettmann

lggwettmann commented on Aug 16, 2019

@lggwettmann

Would it perhaps be an idea to start implementing the JSON-LD instead or as an addition to the basic meta tags? I could imagine that that would bring quite an advantage nowadays and should be (?) more extendable? I haven't done much research and just stumbled upon JSON-LD though.

yakky

yakky commented on Aug 16, 2019

@yakky
MemberAuthor

JSON-LD support is in the works in #76
My goal is to implement less tags and allow people to have a simple way to add the tags they care about :)

yakky

yakky commented on Aug 16, 2019

@yakky
MemberAuthor

Tried that, but didn't show up in the meta tags.

@lggwettmann are you using views or models?

yakky

yakky commented on Aug 16, 2019

@yakky
MemberAuthor

@lggwettmann you may want to check #95 (and https://github.com/nephila/django-meta/pull/95/files#diff-823680934ff274e0f1ecdacdf80a9f61R3 in detail) regarding implementing extra / custom tags properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @yakky@lggwettmann

      Issue actions

        Replace `meta.html` with a more maintenable / extendable approach · Issue #94 · nephila/django-meta