Skip to content

Commit 6b34624

Browse files
committed
Fix sliders not having the expected value if they are never activated
1 parent f51845a commit 6b34624

File tree

3 files changed

+11
-20
lines changed

3 files changed

+11
-20
lines changed

BeatSaberMarkupLanguage/Components/Settings/GenericSliderSetting.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,5 +69,13 @@ public override void Setup()
6969
(slider.transform.Find("SlidingArea") as RectTransform).sizeDelta = new Vector2(-4, -4);
7070
}
7171
}
72+
73+
protected void Awake()
74+
{
75+
if (Slider != null)
76+
{
77+
Slider.Refresh();
78+
}
79+
}
7280
}
7381
}

BeatSaberMarkupLanguage/Components/Settings/ListSliderSetting.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,14 @@ public object Value
2222
public override void Setup()
2323
{
2424
base.Setup();
25+
2526
Slider.minValue = 0;
2627
Slider.maxValue = Values.Count - 1;
2728
Text = Slider.GetComponentInChildren<TextMeshProUGUI>();
2829
Slider.numberOfSteps = Values.Count;
2930
Slider.valueDidChangeEvent += OnValueChanged;
3031

31-
// TextSlider.UpdateVisuals doesn't work properly when disabled
32-
if (Slider.gameObject.activeInHierarchy)
33-
{
34-
ReceiveValue();
35-
}
32+
ReceiveValue();
3633
}
3734

3835
public override void ApplyValue()
@@ -53,11 +50,6 @@ protected string TextForValue(object value)
5350
return Formatter == null ? value.ToString() : (Formatter.Invoke(value) as string);
5451
}
5552

56-
protected void Awake()
57-
{
58-
ReceiveValue();
59-
}
60-
6153
private void OnValueChanged(TextSlider textSlider, float val)
6254
{
6355
Text.text = TextForValue(Value);

BeatSaberMarkupLanguage/Components/Settings/SliderSetting.cs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,7 @@ public override void Setup()
4444
Slider.numberOfSteps = (int)Math.Round((Slider.maxValue - Slider.minValue) / increments) + 1;
4545
Slider.valueDidChangeEvent += OnValueChanged;
4646

47-
// TextSlider.UpdateVisuals doesn't work properly when disabled
48-
if (Slider.gameObject.activeInHierarchy)
49-
{
50-
ReceiveValue();
51-
}
47+
ReceiveValue();
5248
}
5349

5450
public override void ApplyValue()
@@ -86,11 +82,6 @@ internal string TextForValue(float value)
8682
}
8783
}
8884

89-
protected void Awake()
90-
{
91-
ReceiveValue();
92-
}
93-
9485
private void OnValueChanged(TextSlider textSlider, float val)
9586
{
9687
if (isInt)

0 commit comments

Comments
 (0)