Fix back button not working on settings submenus

Author: nicoco007

BeatSaberMarkupLanguage/Harmony Patches/MainMenuInstaller.cs

@@ -37,10 +37,10 @@ private static void Prefix(MainSettingsMenuViewControllersInstaller __instance)
             container.Bind(typeof(GameplaySetup.GameplaySetup), typeof(IInitializable), typeof(IDisposable)).To<GameplaySetup.GameplaySetup>().AsSingle().NonLazy();
 
             // initialize early & dispose late
-            container.BindExecutionOrder<AnimationController>(-1000);
-            container.BindExecutionOrder<BSMLSettings>(-1000);
+            container.BindExecutionOrder<AnimationController>(-900);
+            container.BindExecutionOrder<BSMLSettings>(-900);
             container.BindExecutionOrder<BSMLParser>(-1000);
-            container.BindExecutionOrder<GameplaySetup.GameplaySetup>(-1000);
+            container.BindExecutionOrder<GameplaySetup.GameplaySetup>(-900);
 
             container.Bind(typeof(ModSettingsFlowCoordinator)).FromInstance(BeatSaberUI.CreateFlowCoordinator<ModSettingsFlowCoordinator>());
             container.Bind(typeof(MenuButtonsViewController)).FromInstance(BeatSaberUI.CreateViewController<MenuButtonsViewController>());

BeatSaberMarkupLanguage/Settings/BSMLSettings.cs

@@ -85,6 +85,11 @@ public void Initialize()
         {
             AddButtonToMainScreen().ContinueWith(task => Logger.Log.Error($"Failed to add button to main screen\n{task.Exception}"), TaskContinuationOptions.OnlyOnFaulted);
 
+            foreach (SettingsMenu settingsMenu in SettingsMenus)
+            {
+                settingsMenu.Setup();
+            }
+
             isInitialized = true;
         }
 

BeatSaberMarkupLanguage/Settings/SettingsMenu.cs

@@ -23,7 +23,7 @@ public SettingsMenu(string name, string resource, object host, Assembly assembly
 
         public BSMLParserParams ParserParams { get; private set; }
 
-        public bool DidSetup { get; private set; }
+        public bool DidSetup { get; internal set; }
 
         public string Resource { get; }
 
@@ -45,7 +45,6 @@ public void Setup()
                 ViewController = BeatSaberUI.CreateViewController<ViewController>();
                 SetupViewControllerTransform(ViewController);
                 ParserParams = BSMLParser.Instance.Parse(Utilities.GetResourceContent(Assembly, Resource), ViewController.gameObject, Host);
-                DidSetup = true;
             }
             catch (Exception ex)
             {

BeatSaberMarkupLanguage/Settings/UI/ModSettingsFlowCoordinator.cs

@@ -29,8 +29,8 @@ public void OpenMenu(SettingsMenu menu)
         {
             if (!menu.DidSetup)
             {
-                menu.Setup();
                 menu.ParserParams.AddEvent("back", Back);
+                menu.DidSetup = true;
             }
 
             OpenMenu(menu.ViewController, false, false);
@@ -149,10 +149,7 @@ private void EmitEventToAll(string ev)
         {
             foreach (SettingsMenu menu in BSMLSettings.Instance.SettingsMenus)
             {
-                if (menu.DidSetup)
-                {
-                    menu.ParserParams.EmitEvent(ev);
-                }
+                menu.ParserParams.EmitEvent(ev);
             }
         }
     }