More reverts.

Author: David Grieser

pkg/proc/basejob.go

@@ -166,7 +166,7 @@ func (job *baseJob) startOnce(ctx context.Context, process chan<- *os.Process) e
 		return fmt.Errorf("failed to start job %s: %s", job.Config.Name, err.Error())
 	}
 
-	// Only set job.Cmd if cmd.Start() was successful
+	// Only set job.cmd if cmd.Start() was successful
 	job.cmd = cmd
 
 	if process != nil {
@@ -226,7 +226,7 @@ func (job *baseJob) startOnce(ctx context.Context, process chan<- *os.Process) e
 				return err
 			}
 		}
-		// If job.Cmd or job.Cmd.Process is nil, it means the process didn't start or already cleaned up.
+		// If job.cmd or job.cmd.Process is nil, it means the process didn't start or already cleaned up.
 		l.WithField("job.name", job.Config.Name).Info("context done, but process was not running or already cleaned up.")
 		return ctx.Err() // Return context error
 	}

pkg/proc/job_common.go

@@ -186,7 +186,7 @@ func (job *CommonJob) IsRunning() bool {
 
 func (job *CommonJob) Restart() {
 	job.restart = true
-	// Ensure Cmd and Process are not nil before trying to signal
+	// Ensure job.cmd and job.cmd.Process are not nil before trying to signal
 	if job.cmd != nil && job.cmd.Process != nil {
 		job.SignalAll(syscall.SIGTERM)
 	}
@@ -197,7 +197,7 @@ func (job *CommonJob) Restart() {
 
 func (job *CommonJob) Stop() {
 	job.stop = true
-	// Ensure Cmd and Process are not nil before trying to signal
+	// Ensure job.cmd and job.cmd.Process are not nil before trying to signal
 	if job.cmd != nil && job.cmd.Process != nil {
 		job.SignalAll(syscall.SIGTERM)
 	}
@@ -209,7 +209,7 @@ func (job *CommonJob) Stop() {
 func (job *CommonJob) Status() *CommonJobStatus {
 	running := job.IsRunning()
 	var pid int
-	// Ensure Cmd and Process are not nil before trying to access Pid
+	// Ensure job.cmd and job.cmd.Process are not nil before trying to access Pid
 	if running && job.cmd != nil && job.cmd.Process != nil {
 		pid = job.cmd.Process.Pid
 	}

pkg/proc/job_lazy.go

@@ -125,9 +125,9 @@ func (job *LazyJob) startProcessReaper(ctx context.Context) {
 					continue
 				}
 
-				// Ensure Cmd and Cmd.Process are not nil before accessing PID
+				// Ensure job.cmd and job.cmd.Process are not nil before accessing PID
 				if job.cmd == nil || job.cmd.Process == nil {
-					l.Warn("job.process is not nil, but job.Cmd or job.Cmd.Process is nil; skipping reap cycle")
+					l.Warn("job.process is not nil, but job.cmd or job.cmd.Process is nil; skipping reap cycle")
 					job.lazyStartLock.Unlock()
 					continue
 				}