Skip to content

Commit a680ab6

Browse files
authored
Sync versions, update yarn version, other build updates (#876)
1 parent 7e35562 commit a680ab6

36 files changed

+13873
-10042
lines changed

.github/ISSUE_TEMPLATE/rfc--design-spec.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ labels: dev design
66
assignees: kenotron
77
---
88

9-
# Overview
9+
## Overview
1010

1111
Provide a high level summary of the feature you are trying to build
1212

13-
## Definitions of terms
13+
### Definitions of terms
1414

1515
<dl>
1616
<dt>term 1</dt>
@@ -21,23 +21,23 @@ Provide a high level summary of the feature you are trying to build
2121
<dd>definition 1</dt>
2222
</dl>
2323

24-
## Goals & non-goals
24+
### Goals & non-goals
2525

26-
### Upstream dependencies
26+
#### Upstream dependencies
2727

2828
1. dep 1
2929
2. dep 2
3030
3. dep 3
3131

32-
### Downstream dependencies
32+
#### Downstream dependencies
3333

3434
1. dep 1
3535
2. dep 2
3636
3. dep 3
3737

3838
</details>
3939

40-
# Detailed Design
40+
## Detailed Design
4141

4242
- Use diagrams
4343

@@ -56,23 +56,23 @@ Use images by drag & drop
5656
- Describe different feature areas and how they are architected (designed)
5757
- Make sure another set of developer can roughly understand how your code will be organized after reading this section!
5858

59-
# Test Plan
59+
## Test Plan
6060

6161
- How will you make sure these features are to be tested
6262
- Specify if leveraging any NEW test framework or techniques
6363

64-
# Performance, Resilience, Monitoring
64+
## Performance, Resilience, Monitoring
6565

6666
- Discuss any impact on performance (both as a developer and as a consumer)
6767
- Any expected change in the ability to deal with spotty networks (resilience?)
6868
- How will you monitor or collect telemetry on the features?
6969

70-
# Security & Privacy
70+
## Security & Privacy
7171

7272
- Will the feature have any security or privacy issues?
7373
- What are some ways to mitigate these issues?
7474

75-
# Accessibility
75+
## Accessibility
7676

7777
- How will your feature conform to accessibility guidelines
7878
- Check on how you will handle:
@@ -82,12 +82,12 @@ Use images by drag & drop
8282
- High DPI support
8383
- High Contrast support
8484

85-
# World Readiness
85+
## World Readiness
8686

8787
- Globalization: how does yoru feature invoke display or manipulate display of currency, dates, timezones, names?
8888
- Localization: how does your feature address localization?
8989

90-
# Execution Plan
90+
## Execution Plan
9191

9292
List out the work items and/or PRs here:
9393

.github/workflows/docusaurus-pr.yml

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,41 @@
1-
name: Test deployment
1+
name: Docs - PR
22

33
on:
44
pull_request:
55
branches:
66
- master
77
paths:
8+
- .github/workflows/docusaurus-pr.yml
89
- "docs/**"
910

11+
concurrency:
12+
# For PRs, use the ref (branch) in the concurrency group so that new pushes cancel any old runs.
13+
# For pushes to master, ideally we wouldn't set a concurrency group, but github actions doesn't
14+
# support conditional blocks of settings, so we use the SHA so the "group" is unique.
15+
group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.sha || github.ref }}
16+
cancel-in-progress: true
17+
18+
permissions: {}
19+
1020
jobs:
1121
test-deploy:
1222
name: Test deployment
1323
runs-on: ubuntu-latest
1424
steps:
15-
- uses: actions/checkout@v3
16-
- uses: actions/setup-node@v3
25+
- uses: actions/checkout@v4
26+
27+
- uses: actions/setup-node@v4
1728
with:
18-
node-version: 18.x
19-
- name: Test build
29+
node-version-file: .nvmrc
30+
31+
- run: yarn --immutable
2032
working-directory: docs
21-
run: |
22-
yarn install --frozen-lockfile
23-
yarn build
24-
- uses: actions/upload-artifact@v3
33+
34+
- name: Build website
35+
working-directory: docs
36+
run: yarn build
37+
38+
- uses: actions/upload-artifact@v4
2539
with:
2640
name: docs
2741
path: docs/build/**

.github/workflows/docusaurus-release.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
name: Deploy to GitHub Pages
1+
name: Docs - Release
22

33
on:
44
push:
55
branches:
66
- master
77
paths:
8+
- .github/workflows/docusaurus-release.yml
89
- "docs/**"
910

1011
permissions:
@@ -15,20 +16,23 @@ jobs:
1516
name: Deploy to GitHub Pages
1617
runs-on: ubuntu-latest
1718
steps:
18-
- uses: actions/checkout@v3
19-
- uses: actions/setup-node@v3
19+
- uses: actions/checkout@v4
20+
21+
- uses: actions/setup-node@v4
2022
with:
21-
node-version: 18.x
23+
node-version-file: .nvmrc
24+
25+
- run: yarn --immutable
26+
working-directory: docs
27+
2228
- name: Build website
2329
working-directory: docs
24-
run: |
25-
yarn install --frozen-lockfile
26-
yarn build
30+
run: yarn build
2731

2832
# Popular action to deploy to GitHub Pages:
2933
# Docs: https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-docusaurus
3034
- name: Deploy to GitHub Pages
31-
uses: peaceiris/actions-gh-pages@v3
35+
uses: peaceiris/actions-gh-pages@v4
3236
with:
3337
github_token: ${{ secrets.GITHUB_TOKEN }}
3438
destination_dir: docs

.github/workflows/pr.yml

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,46 +7,52 @@ on:
77
pull_request:
88
branches: [master, v1]
99
# Ignoring the docs prevents PRs touching only docs from succeeding.
10-
# Also, the docs do have a build step which must succeed for overall builds to succeed.
1110
# paths-ignore:
1211
# - "docs/**"
1312

13+
concurrency:
14+
# For PRs, use the ref (branch) in the concurrency group so that new pushes cancel any old runs.
15+
# For pushes to master, ideally we wouldn't set a concurrency group, but github actions doesn't
16+
# support conditional blocks of settings, so we use the SHA so the "group" is unique.
17+
group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.sha || github.ref }}
18+
cancel-in-progress: true
19+
20+
permissions: {}
21+
1422
jobs:
1523
build:
1624
strategy:
1725
matrix:
18-
node-version: [18.x, 20.x, 22.x]
26+
node: [18.x, 20.x, 22.x]
1927
os: [ubuntu-latest, windows-latest, macos-latest]
2028

2129
runs-on: ${{ matrix.os }}
2230

2331
steps:
24-
- uses: actions/checkout@v3
25-
with:
26-
fetch-depth: 0
32+
- uses: actions/checkout@v4
2733

28-
- name: Use Node.js ${{ matrix.node-version }}
29-
uses: actions/setup-node@v3
34+
- name: Use Node.js ${{ matrix.node }}
35+
uses: actions/setup-node@v4
3036
with:
31-
node-version: ${{ matrix.node-version }}
37+
node-version: ${{ matrix.node }}
3238

33-
- run: yarn
39+
- run: yarn --immutable
3440

3541
- name: Code Format Check
36-
if: ${{ matrix.os == 'ubuntu-latest' }}
42+
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }}
3743
run: yarn format:check
3844

3945
- name: Check Change Files
40-
if: ${{ matrix.os == 'ubuntu-latest' }}
46+
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }}
4147
run: yarn checkchange
4248

4349
# @see https://www.npmjs.com/package/syncpack
4450
- name: Check consistent package.json dep versions
45-
if: ${{ matrix.os == 'ubuntu-latest' }}
51+
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }}
4652
run: yarn syncpack list-mismatches
4753

4854
- name: Dependency checks
49-
if: ${{ matrix.os == 'ubuntu-latest' }}
55+
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }}
5056
run: yarn lage depcheck
5157

5258
- name: Build, Test, Lint

.github/workflows/release.yml

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name: Release
22

33
on:
4+
# release daily at 8am UTC (midnight or 1am pacific)
5+
# https://crontab-generator.org/
6+
schedule:
7+
- cron: "0 8 * * *"
8+
# or manual trigger
49
workflow_dispatch:
5-
push:
6-
branches: [master, v1]
7-
paths-ignore:
8-
- "docs/**"
910

10-
permissions:
11-
contents: write
11+
permissions: {}
1212

1313
# Only run one release at a time to avoid duplicate attempts to publish particular versions.
1414
# To avoid backups after multiple pushes in rapid succession, the prerelease job below emulates
@@ -25,13 +25,13 @@ jobs:
2525
# Also skip this run if there are any newer pending runs.
2626
prerelease:
2727
runs-on: ubuntu-latest
28+
permissions:
29+
actions: read
2830
outputs:
2931
shouldRelease: ${{ steps.shouldRelease.outputs.shouldRelease }}
3032
steps:
3133
- name: Check out code
32-
uses: actions/checkout@v3
33-
with:
34-
fetch-depth: 0
34+
uses: actions/checkout@v4
3535

3636
# Cancel the release if a newer run is pending or no change files are present
3737
- uses: ecraig12345/beachball-actions/should-release@v1
@@ -50,22 +50,17 @@ jobs:
5050
# This environment contains secrets needed for publishing
5151
environment: release
5252

53-
strategy:
54-
matrix:
55-
node-version: [18.x]
56-
5753
steps:
58-
- uses: actions/checkout@v3
54+
- uses: actions/checkout@v4
5955
with:
6056
# Don't save creds in the git config (so it's easier to override later)
6157
persist-credentials: false
6258

63-
- name: Use Node.js ${{ matrix.node-version }}
64-
uses: actions/setup-node@v3
59+
- uses: actions/setup-node@v4
6560
with:
66-
node-version: ${{ matrix.node-version }}
61+
node-version-file: .nvmrc
6762

68-
- run: yarn
63+
- run: yarn --immutable
6964

7065
- run: yarn ci --concurrency 2 --verbose
7166

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
18

.prettierignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@
44

55
# Generated or imported files
66
change/*.json
7+
docs/build
78
CHANGELOG.*
89
LICENSE
910
SECURITY.md
1011
*.snap
1112
yarn.lock
13+
**/.yarn
1214
# this is a test fixture
1315
yarn.js
14-
.yarn/**
16+
**/.rush/temp
1517

1618
# These lines from .gitignore can be removed after prettier 3 update
1719
node_modules

.vscode/settings.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@
88
"search.exclude": {
99
"**/lib": true,
1010
"**/node_modules": true,
11+
"**/.docusaurus": true,
12+
"**/.yarn": true,
13+
"**/yarn/yarn.js": true,
14+
"**/docs/build": true,
1115
"**/*.code-search": true
1216
},
1317
"[typescript]": {

0 commit comments

Comments
 (0)