Skip to content

The defines in gravity_optionals.h are Always Defined #426

Open
@jockm

Description

@jockm

In optionals gravity_optionals.h you will find the following (lines 12-14):

#ifndef GRAVITY_INCLUDE_MATH
#define GRAVITY_INCLUDE_MATH
#endif

So if moth hasn't been defined, then math is defined, if you use optionals, which are included by default. So the mere act of including gravity_optionals.h forces math to be included.

This is also true of GRAVITY_INCLUDE_JSON, GRAVITY_INCLUDE_ENV, and GRAVITY_INCLUDE_FILE

If they aren't optional, then there is no need for the #ifdefs, if they are optional then you shouldn't force them. Either way this should probably be changed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions