fix: patch add initial member to group

Author: msiegenthaler

core/src/main/scala/scim/model/PatchOp.scala

@@ -28,8 +28,17 @@ object PatchOp {
           case None =>
             addIt(root)(on, context.value)
           case Some(ap@AttributePath(name, _, None)) =>
-            addIt(ap.basePath(context.defaultSchema))(on, context.value)
-          case Some(ap@AttributePath(name, _, Some(_))) =>
+            val jsonPath = ap.basePath(context.defaultSchema)
+            if (jsonPath.json.isEmpty(on)) {
+              val v = if (context.value.isArray) context.value else Json.arr(context.value)
+              on.asObject.map(_.add(name, v))
+                .map(Json.fromJsonObject)
+                .map(Right.apply)
+                .getOrElse(Left("entity must be on object"))
+            } else {
+              addIt(ap.basePath(context.defaultSchema))(on, context.value)
+            }
+          case Some(ap@AttributePath(_, _, Some(_))) =>
             Left("adding a sub attribute is not supported")
           case Some(FilteredAttributePath(_, _, _, _)) =>
             Left("add with filter is not supported")

core/src/test/scala/scim/model/Jsons.scala

@@ -214,4 +214,19 @@ object Jsons {
       |         ]
       |       }
       |""".stripMargin)
+  val groupEmpty = parse(
+    """
+      |       {
+      |         "id": "6c5bb468-14b2-4183-baf2-06d523e03bd3",
+      |         "schemas": ["urn:ietf:params:scim:schemas:core:2.0:Group"],
+      |         "displayName": "Group C",
+      |         "meta": {
+      |           "resourceType": "Group",
+      |           "created": "2011-08-01T18:29:50.873Z",
+      |           "lastModified": "2011-08-01T18:29:50.873Z",
+      |           "location": "https://example.com/v2/Groups/6c5bb468-14b2-4183-baf2-06d523e03bd3",
+      |           "version": "W\/\"wGB85s2QJMjiNnuI\""
+      |         }
+      |       }
+      |""".stripMargin)
 }

core/src/test/scala/scim/model/PatchOpSpec.scala

@@ -80,6 +80,56 @@ class PatchOpSpec extends AnyFunSpec with Checkers with Matchers with OptionValu
         patch.applyTo(Schema.Group)(before) should be(Right(after))
       }
 
+      it("should add a first member to a group (element to Null->array)") {
+        val patch = patchOp(
+          """
+            |   { "schemas":
+            |      ["urn:ietf:params:scim:api:messages:2.0:PatchOp"],
+            |     "Operations":[
+            |       {
+            |        "op":"add",
+            |        "path":"members",
+            |        "value":[
+            |         {
+            |           "display": "Babs Jensen",
+            |           "$ref":
+            |   "https://example.com/v2/Users/2819c223...413861904646",
+            |           "value": "2819c223-7f76-453a-919d-413861904646"
+            |         }
+            |        ]
+            |       }
+            |     ]
+            |   }
+            |""".stripMargin)
+
+        val before = Jsons.groupEmpty
+
+        val after = parseJson(
+          """
+            |       {
+            |         "id": "6c5bb468-14b2-4183-baf2-06d523e03bd3",
+            |         "schemas": ["urn:ietf:params:scim:schemas:core:2.0:Group"],
+            |         "displayName": "Group C",
+            |         "meta": {
+            |           "resourceType": "Group",
+            |           "created": "2011-08-01T18:29:50.873Z",
+            |           "lastModified": "2011-08-01T18:29:50.873Z",
+            |           "location": "https://example.com/v2/Groups/6c5bb468-14b2-4183-baf2-06d523e03bd3",
+            |           "version": "W\/\"wGB85s2QJMjiNnuI\""
+            |         },
+            |         "members": [
+            |           {
+            |             "display": "Babs Jensen",
+            |             "$ref": "https://example.com/v2/Users/2819c223...413861904646",
+            |             "value": "2819c223-7f76-453a-919d-413861904646"
+            |           }
+            |         ]
+            |       }
+            |""".stripMargin)
+
+        patch.applyTo(Schema.Group)(before) should be(Right(after))
+      }
+
       it("should add new attribute") {
         val patch = patchOp(
           """