Simplify gradle kts (square#6931)

Goooler · web-flow · commit 8debc78b00a6 · 2021-11-27T12:31:27.000Z
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -90,7 +90,7 @@ subprojects {
     exclude("**/CipherSuite.java")
   }
 
-  val checkstyleConfig by configurations.creating
+  val checkstyleConfig: Configuration by configurations.creating
   dependencies {
     checkstyleConfig(Dependencies.checkStyle) {
       isTransitive = false
@@ -110,7 +110,7 @@ subprojects {
     annotation = "okhttp3.internal.SuppressSignatureCheck"
     sourceSets = listOf(project.sourceSets["main"])
   }
-  val signature by configurations.getting
+  val signature: Configuration by configurations.getting
   dependencies {
     signature(Dependencies.signatureAndroid21)
     signature(Dependencies.signatureJava18)
@@ -129,7 +129,7 @@ subprojects {
   val platform = System.getProperty("okhttp.platform", "jdk9")
   val testJavaVersion = System.getProperty("test.java.version", "11").toInt()
 
-  val testRuntimeOnly by configurations.getting
+  val testRuntimeOnly: Configuration by configurations.getting
   dependencies {
     testRuntimeOnly(Dependencies.junit5JupiterEngine)
     testRuntimeOnly(Dependencies.junit5VintageEngine)
@@ -236,6 +236,6 @@ subprojects {
   }
 }
 
-tasks.withType<Wrapper> {
+tasks.wrapper {
   distributionType = Wrapper.DistributionType.ALL
 }
diff --git a/mockwebserver-deprecated/build.gradle.kts b/mockwebserver-deprecated/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import me.champeau.gradle.japicmp.JapicmpTask
 
 plugins {
@@ -48,6 +47,6 @@ tasks.register<JapicmpTask>("japicmp") {
 }.let(tasks.check::dependsOn)
 
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/mockwebserver-junit4/build.gradle.kts b/mockwebserver-junit4/build.gradle.kts
@@ -1,6 +1,5 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 
 plugins {
   kotlin("jvm")
@@ -21,6 +20,6 @@ dependencies {
   testImplementation(Dependencies.assertj)
 }
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/mockwebserver-junit5/build.gradle.kts b/mockwebserver-junit5/build.gradle.kts
@@ -1,6 +1,5 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 
 plugins {
   kotlin("jvm")
@@ -30,6 +29,6 @@ dependencies {
   testImplementation(Dependencies.kotlinJunit5)
 }
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/mockwebserver/build.gradle.kts b/mockwebserver/build.gradle.kts
@@ -1,6 +1,5 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 
 plugins {
   kotlin("jvm")
@@ -24,6 +23,6 @@ dependencies {
   testImplementation(Dependencies.assertj)
 }
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okcurl/build.gradle.kts b/okcurl/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import java.nio.charset.StandardCharsets
 import org.apache.tools.ant.taskdefs.condition.Os
 
@@ -62,7 +61,7 @@ graal {
   }
 }
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
 
@@ -73,5 +72,5 @@ tasks.register<Copy>("copyResourcesTemplates") {
   filteringCharset = StandardCharsets.UTF_8.toString()
 }.let {
   tasks.processResources.dependsOn(it)
-  tasks.named("javaSourcesJar").dependsOn(it)
+  tasks["javaSourcesJar"].dependsOn(it)
 }
diff --git a/okhttp-bom/build.gradle.kts b/okhttp-bom/build.gradle.kts
@@ -13,8 +13,8 @@ dependencies {
   }
 }
 
-extensions.configure<PublishingExtension> {
-  publications.create("maven", MavenPublication::class) {
-    from(project.components.getByName("javaPlatform"))
+publishing {
+  publications.create<MavenPublication>("maven") {
+    from(project.components["javaPlatform"])
   }
 }
diff --git a/okhttp-brotli/build.gradle.kts b/okhttp-brotli/build.gradle.kts
@@ -1,6 +1,5 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 
 plugins {
   kotlin("jvm")
@@ -25,6 +24,6 @@ dependencies {
   testImplementation(Dependencies.assertj)
 }
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okhttp-dnsoverhttps/build.gradle.kts b/okhttp-dnsoverhttps/build.gradle.kts
@@ -1,6 +1,5 @@
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 
 plugins {
   kotlin("jvm")
@@ -27,6 +26,6 @@ dependencies {
   testImplementation(Dependencies.assertj)
 }
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okhttp-logging-interceptor/build.gradle.kts b/okhttp-logging-interceptor/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import me.champeau.gradle.japicmp.JapicmpTask
 
 plugins {
@@ -41,6 +40,6 @@ tasks.register<JapicmpTask>("japicmp") {
   isIncludeSynthetic = true
 }.let(tasks.check::dependsOn)
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okhttp-sse/build.gradle.kts b/okhttp-sse/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import me.champeau.gradle.japicmp.JapicmpTask
 
 plugins {
@@ -43,6 +42,6 @@ tasks.register<JapicmpTask>("japicmp") {
   )
 }.let(tasks.check::dependsOn)
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okhttp-tls/build.gradle.kts b/okhttp-tls/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import me.champeau.gradle.japicmp.JapicmpTask
 
 plugins {
@@ -49,6 +48,6 @@ tasks.register<JapicmpTask>("japicmp") {
   )
 }.let(tasks.check::dependsOn)
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okhttp-urlconnection/build.gradle.kts b/okhttp-urlconnection/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import me.champeau.gradle.japicmp.JapicmpTask
 
 plugins {
@@ -44,6 +43,6 @@ tasks.register<JapicmpTask>("japicmp") {
 }.let(tasks.check::dependsOn)
 
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
diff --git a/okhttp/build.gradle.kts b/okhttp/build.gradle.kts
@@ -1,7 +1,6 @@
 import com.android.build.gradle.internal.tasks.factory.dependsOn
 import com.vanniktech.maven.publish.JavadocJar
 import com.vanniktech.maven.publish.KotlinJvm
-import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import java.nio.charset.StandardCharsets
 import me.champeau.gradle.japicmp.JapicmpTask
 
@@ -61,12 +60,10 @@ normalization {
 }
 
 // Expose OSGi jars to the test environment.
-configurations {
-  create("osgiTestDeploy")
-}
+val osgiTestDeploy: Configuration by configurations.creating
 
 tasks.register<Copy>("copyOsgiTestDeployment") {
-  from(configurations["osgiTestDeploy"])
+  from(osgiTestDeploy)
   into("$buildDir/resources/test/okhttp3/osgi/deployments")
 }.let(tasks.test::dependsOn)
 
@@ -173,7 +170,7 @@ tasks.register<JapicmpTask>("japicmp") {
   )
 }.let(tasks.check::dependsOn)
 
-configure<MavenPublishBaseExtension> {
+mavenPublishing {
   configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
 }
 
@@ -184,6 +181,6 @@ tasks.register<Copy>("copyJavaTemplates") {
   filteringCharset = StandardCharsets.UTF_8.toString()
 }.let {
   tasks.compileKotlin.dependsOn(it)
-  tasks.named("javaSourcesJar").dependsOn(it)
+  tasks["javaSourcesJar"].dependsOn(it)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ subprojects {`
`90`	`90`	`exclude("**/CipherSuite.java")`
`91`	`91`	`}`
`92`	`92`
`93`		`- val checkstyleConfig by configurations.creating`
	`93`	`+ val checkstyleConfig: Configuration by configurations.creating`
`94`	`94`	`dependencies {`
`95`	`95`	`checkstyleConfig(Dependencies.checkStyle) {`
`96`	`96`	`isTransitive = false`
`@@ -110,7 +110,7 @@ subprojects {`
`110`	`110`	`annotation = "okhttp3.internal.SuppressSignatureCheck"`
`111`	`111`	`sourceSets = listOf(project.sourceSets["main"])`
`112`	`112`	`}`
`113`		`- val signature by configurations.getting`
	`113`	`+ val signature: Configuration by configurations.getting`
`114`	`114`	`dependencies {`
`115`	`115`	`signature(Dependencies.signatureAndroid21)`
`116`	`116`	`signature(Dependencies.signatureJava18)`
`@@ -129,7 +129,7 @@ subprojects {`
`129`	`129`	`val platform = System.getProperty("okhttp.platform", "jdk9")`
`130`	`130`	`val testJavaVersion = System.getProperty("test.java.version", "11").toInt()`
`131`	`131`
`132`		`- val testRuntimeOnly by configurations.getting`
	`132`	`+ val testRuntimeOnly: Configuration by configurations.getting`
`133`	`133`	`dependencies {`
`134`	`134`	`testRuntimeOnly(Dependencies.junit5JupiterEngine)`
`135`	`135`	`testRuntimeOnly(Dependencies.junit5VintageEngine)`
`@@ -236,6 +236,6 @@ subprojects {`
`236`	`236`	`}`
`237`	`237`	`}`
`238`	`238`
`239`		`-tasks.withType<Wrapper> {`
	`239`	`+tasks.wrapper {`
`240`	`240`	`distributionType = Wrapper.DistributionType.ALL`
`241`	`241`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`import com.vanniktech.maven.publish.JavadocJar`
`2`	`2`	`import com.vanniktech.maven.publish.KotlinJvm`
`3`		`-import com.vanniktech.maven.publish.MavenPublishBaseExtension`
`4`	`3`
`5`	`4`	`plugins {`
`6`	`5`	`kotlin("jvm")`
`@@ -21,6 +20,6 @@ dependencies {`
`21`	`20`	`testImplementation(Dependencies.assertj)`
`22`	`21`	`}`
`23`	`22`
`24`		`-configure<MavenPublishBaseExtension> {`
	`23`	`+mavenPublishing {`
`25`	`24`	`configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))`
`26`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`import com.android.build.gradle.internal.tasks.factory.dependsOn`
`2`	`2`	`import com.vanniktech.maven.publish.JavadocJar`
`3`	`3`	`import com.vanniktech.maven.publish.KotlinJvm`
`4`		`-import com.vanniktech.maven.publish.MavenPublishBaseExtension`
`5`	`4`	`import java.nio.charset.StandardCharsets`
`6`	`5`	`import org.apache.tools.ant.taskdefs.condition.Os`
`7`	`6`
`@@ -62,7 +61,7 @@ graal {`
`62`	`61`	`}`
`63`	`62`	`}`
`64`	`63`
`65`		`-configure<MavenPublishBaseExtension> {`
	`64`	`+mavenPublishing {`
`66`	`65`	`configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))`
`67`	`66`	`}`
`68`	`67`
`@@ -73,5 +72,5 @@ tasks.register<Copy>("copyResourcesTemplates") {`
`73`	`72`	`filteringCharset = StandardCharsets.UTF_8.toString()`
`74`	`73`	`}.let {`
`75`	`74`	`tasks.processResources.dependsOn(it)`
`76`		`- tasks.named("javaSourcesJar").dependsOn(it)`
	`75`	`+ tasks["javaSourcesJar"].dependsOn(it)`
`77`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,8 @@ dependencies {`
`13`	`13`	`}`
`14`	`14`	`}`
`15`	`15`
`16`		`-extensions.configure<PublishingExtension> {`
`17`		`- publications.create("maven", MavenPublication::class) {`
`18`		`- from(project.components.getByName("javaPlatform"))`
	`16`	`+publishing {`
	`17`	`+ publications.create<MavenPublication>("maven") {`
	`18`	`+ from(project.components["javaPlatform"])`
`19`	`19`	`}`
`20`	`20`	`}`