[containerd] nri_enabled not working excepted

[tico88612]

What happened?

After Containerd 2.0.0, NRI (Node Resource Interface) default is enabled.

FYI: https://github.com/containerd/containerd/blob/main/docs/NRI.md

The way it's written now, the NRI is enabled, whether false or true.

kubespray/roles/container-engine/containerd/templates/config.toml.j2

Lines 79 to 82 in d304966

	{% if nri_enabled %}
	[plugins."io.containerd.nri.v1.nri"]
	disable = false
	{% endif %}

What did you expect to happen?

If container_manager is containerd, nri_enabled should be true; otherwise, it should be false.

And follow the Containerd instructions to disable NRI if nri_enabled is false.

How can we reproduce it (as minimally and precisely as possible)?

container_manager: containerd
nri_enabled: false

OS

Other|Unsupported

Version of Ansible

N/A

Version of Python

N/A

Version of Kubespray (commit)

N/A

Network plugin used

calico

Full inventory with variables

N/A

Command used to invoke ansible

N/A

Output of ansible run

N/A

Anything else we need to know

No response

[tico88612]

/good-first-issue

[k8s-ci-robot]

@tico88612:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[manju956]

/assign

[manju956]

@tico88612 I have made some changes to config template file. Now to test if the changes render config.toml file with NRI disabled, are there ways to test locally in a simpler manner?

Also, the config values mentioned in reproducing the issue container_manager: containerd nri_enabled: false
should go to https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/main.yml ?

[tico88612]

I have made some changes to config template file. Now to test if the changes render config.toml file with NRI disabled, are there ways to test locally in a simpler manner?

I think you can check if /var/run/nri/nri.sock exists.

Also, the config values mentioned in reproducing the issue container_manager: containerd nri_enabled: false
should go to https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/main.yml ?

Yes, this is the default value.

[tico88612]

@manju956 Any updates?

[tico88612]

/unassign @manju956

[ShinyaIshitobi]

/assign