Skip to content

Consider adding Deleting phase for machine deployments #12220

Open
@fabriziopandini

Description

@fabriziopandini
Member

Before 1.11, machine deployment wasn't updating replica counters of phase during deletion

With v1.11 this was fixed, but when deleting a machine deployment phase is scalingDown which is correct except for when replicas = 0 and deletion is blocked by a finalizer.

We can consider adding a Deleting phase for machine deployments to use at the end of the deletion process (or during the entire deletion process).

However, doing this now has the downside to figure out what to do for up/down conversions, so I think we should defer to when v1beta1 is removed (or to when all the priority work for v1beta2 is completed)

Activity

added
needs-priorityIndicates an issue lacks a `priority/foo` label and requires one.
needs-kindIndicates a PR lacks a `kind/foo` label and requires one.
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on May 15, 2025
sbueringer

sbueringer commented on May 15, 2025

@sbueringer
Member

Sounds good

/triage accepted

added
triage/acceptedIndicates an issue or PR is ready to be actively worked on.
and removed
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on May 15, 2025
added
priority/backlogHigher priority than priority/awaiting-more-evidence.
and removed
triage/acceptedIndicates an issue or PR is ready to be actively worked on.
on May 15, 2025
added
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
and removed
needs-priorityIndicates an issue lacks a `priority/foo` label and requires one.
on May 15, 2025
added
kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.
on May 15, 2025
removed
needs-kindIndicates a PR lacks a `kind/foo` label and requires one.
on May 15, 2025
added
triage/acceptedIndicates an issue or PR is ready to be actively worked on.
on May 15, 2025
removed
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on May 15, 2025

6 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/machinedeploymentIssues or PRs related to machinedeploymentskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.priority/backlogHigher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @sbueringer@fabriziopandini@k8s-ci-robot@arshadd-b

      Issue actions

        Consider adding Deleting phase for machine deployments · Issue #12220 · kubernetes-sigs/cluster-api