Merge pull request #12347 from alimaazamat/race-conditions

🐛 Fix race condition in InMemoryMachine controller tests

Author: k8s-ci-robot

test/infrastructure/docker/internal/controllers/backends/inmemory/inmemorymachine_controller_test.go

@@ -363,6 +363,9 @@ func TestReconcileNormalEtcd(t *testing.T) {
 		r.InMemoryManager.AddResourceGroup(klog.KObj(cluster).String())
 		c := r.InMemoryManager.GetResourceGroup(klog.KObj(cluster).String()).GetClient()
 
+		// Note: We have to update the lastTransitionTime of the NodeProvisioned condition
+		// to ensure provisioning time is not expired yet.
+		updateNodeProvisionedTime(inMemoryMachineWithNodeProvisioned1)
 		res, err := r.reconcileNormalETCD(ctx, cluster, cpMachine, inMemoryMachineWithNodeProvisioned1)
 		g.Expect(err).ToNot(HaveOccurred())
 		g.Expect(res.IsZero()).To(BeFalse())
@@ -590,6 +593,9 @@ func TestReconcileNormalApiServer(t *testing.T) {
 		r.InMemoryManager.AddResourceGroup(klog.KObj(cluster).String())
 		c := r.InMemoryManager.GetResourceGroup(klog.KObj(cluster).String()).GetClient()
 
+		// Note: We have to update the lastTransitionTime of the NodeProvisioned condition
+		// to ensure provisioning time is not expired yet.
+		updateNodeProvisionedTime(inMemoryMachineWithNodeProvisioned)
 		res, err := r.reconcileNormalAPIServer(ctx, cluster, cpMachine, inMemoryMachineWithNodeProvisioned)
 		g.Expect(err).ToNot(HaveOccurred())
 		g.Expect(res.IsZero()).To(BeFalse())
@@ -821,3 +827,21 @@ func newSelfSignedCACert(key *rsa.PrivateKey) (*x509.Certificate, error) {
 	c, err := x509.ParseCertificate(b)
 	return c, errors.WithStack(err)
 }
+
+func updateNodeProvisionedTime(machine *infrav1.DevMachine) {
+	for i := range machine.Status.Conditions {
+		if machine.Status.Conditions[i].Type == string(infrav1.NodeProvisionedCondition) {
+			machine.Status.Conditions[i].LastTransitionTime = metav1.Now()
+			return
+		}
+	}
+
+	if machine.Status.Deprecated != nil && machine.Status.Deprecated.V1Beta1 != nil {
+		for i := range machine.Status.Deprecated.V1Beta1.Conditions {
+			if machine.Status.Deprecated.V1Beta1.Conditions[i].Type == infrav1.NodeProvisionedCondition {
+				machine.Status.Deprecated.V1Beta1.Conditions[i].LastTransitionTime = metav1.Now()
+				return
+			}
+		}
+	}
+}