Skip to content

feat: krw test for rh-push-to-external-registry #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scoheb
Copy link
Member

@scoheb scoheb commented Jul 11, 2025

Describe your changes

  • add new test for rh-push-to-external-registry pipeline
  • add new script that gets a result from a task run in a
    pipelinerun
  • add check for imageIds that were created.

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting
  • I have run the README.md generator script in .github/scripts/readme_generator.sh and verified the results using .github/scripts/check_readme.sh

@scoheb scoheb requested a review from a team as a code owner July 11, 2025 16:20
@scoheb scoheb force-pushed the rh-push-to-external-registry-krw branch 3 times, most recently from e405e11 to bd09a91 Compare July 14, 2025 20:37
jinqi7
jinqi7 previously approved these changes Jul 15, 2025
Copy link
Collaborator

@jinqi7 jinqi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2025
@scoheb scoheb force-pushed the rh-push-to-external-registry-krw branch from bd09a91 to 0275776 Compare July 15, 2025 17:05
@openshift-ci openshift-ci bot removed the lgtm label Jul 15, 2025
@scoheb scoheb requested review from johnbieren and jinqi7 July 15, 2025 17:05
- add new test for rh-push-to-external-registry pipeline
- add new script that gets a result from a task run in a
  pipelinerun
- add check for imageIds that were created.

Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb force-pushed the rh-push-to-external-registry-krw branch from 0275776 to a7d7c7c Compare July 15, 2025 17:10
@openshift-ci openshift-ci bot added the lgtm label Jul 16, 2025
@scoheb scoheb merged commit 60395f2 into konflux-ci:development Jul 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants