-
Notifications
You must be signed in to change notification settings - Fork 80
feat: krw test for rh-push-to-external-registry #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scoheb
merged 1 commit into
konflux-ci:development
from
scoheb:rh-push-to-external-registry-krw
Jul 16, 2025
Merged
feat: krw test for rh-push-to-external-registry #1201
scoheb
merged 1 commit into
konflux-ci:development
from
scoheb:rh-push-to-external-registry-krw
Jul 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinqi7
reviewed
Jul 14, 2025
integration-tests/rh-push-to-external-registry/resources/managed/rpa.yaml
Outdated
Show resolved
Hide resolved
jinqi7
reviewed
Jul 14, 2025
integration-tests/rh-push-to-external-registry/resources/managed/rpa.yaml
Outdated
Show resolved
Hide resolved
jinqi7
reviewed
Jul 14, 2025
integration-tests/rh-push-to-external-registry/resources/managed/rpa.yaml
Outdated
Show resolved
Hide resolved
jinqi7
reviewed
Jul 14, 2025
johnbieren
reviewed
Jul 14, 2025
integration-tests/rh-push-to-external-registry/resources/managed/sa.yaml
Outdated
Show resolved
Hide resolved
integration-tests/rh-push-to-external-registry/utils/cleanup-resources.sh
Outdated
Show resolved
Hide resolved
integration-tests/rh-push-to-external-registry/utils/cleanup-resources.sh
Outdated
Show resolved
Hide resolved
e405e11
to
bd09a91
Compare
jinqi7
previously approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bd09a91
to
0275776
Compare
- add new test for rh-push-to-external-registry pipeline - add new script that gets a result from a task run in a pipelinerun - add check for imageIds that were created. Signed-off-by: Scott Hebert <[email protected]>
0275776
to
a7d7c7c
Compare
jinqi7
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
pipelinerun
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>
.github/scripts/readme_generator.sh
and verified the results using.github/scripts/check_readme.sh