-
Notifications
You must be signed in to change notification settings - Fork 80
fix: force runasuser for reduce-snapshot #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scoheb
merged 1 commit into
konflux-ci:development
from
scoheb:fix-permission-denied-reduce-snapshot
Jul 18, 2025
Merged
fix: force runasuser for reduce-snapshot #1199
scoheb
merged 1 commit into
konflux-ci:development
from
scoheb:fix-permission-denied-reduce-snapshot
Jul 18, 2025
+76
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
previously approved these changes
Jul 11, 2025
before:
after:
|
2861332
to
822c603
Compare
822c603
to
4bb4e38
Compare
3228f22
to
542d1f9
Compare
/retest |
542d1f9
to
57ab659
Compare
/retest |
f0b8777
to
a320f4e
Compare
re-running 2 failed tests |
/retest |
1 similar comment
/retest |
a320f4e
to
253613d
Compare
theflockers
reviewed
Jul 16, 2025
stepactions/skip-trusted-artifact-operations/skip-trusted-artifact-operations.yaml
Show resolved
Hide resolved
253613d
to
685f48b
Compare
johnbieren
reviewed
Jul 16, 2025
stepactions/skip-trusted-artifact-operations/skip-trusted-artifact-operations.yaml
Outdated
Show resolved
Hide resolved
f025987
to
a0e3bbf
Compare
/retest |
jinqi7
approved these changes
Jul 17, 2025
theflockers
approved these changes
Jul 17, 2025
/retest |
a0e3bbf
to
23b3496
Compare
Are we ok to merge this? It's blocking the pipeline. |
/retest |
seanconroy2021
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
23b3496
to
e346d24
Compare
New changes are detected. LGTM label has been removed. |
- This is a workaround for a problem observed on a particular cluster where the use-trusted-artifacts step runs with root user causing a file or folder to not be readable in later steps. There might be solution coming related to the security context constraints on the cluster, but setting this explicitly here should probably be harmless either way. - Also add protection for skip-trusted-artifact-operations to better handle permission issues. Signed-off-by: Scott Hebert <[email protected]>
e346d24
to
5503228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>
.github/scripts/readme_generator.sh
and verified the results using.github/scripts/check_readme.sh