Skip to content

fix: protect against large result values #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

scoheb
Copy link
Member

@scoheb scoheb commented Jul 10, 2025

Describe your changes

  • protect against large result values that are contributed
  • Seen in ocp release pipeline:

/tekton/scripts/script-2-5fjfr: line 13: /usr/bin/jq: Argument list too long

  • RESULTS_JSON=

Assisted-by: Cursor

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting
  • I have run the README.md generator script in .github/scripts/readme_generator.sh and verified the results using .github/scripts/check_readme.sh

- protect against large result values that are
  contributed
- Seen in ocp release pipeline:

/tekton/scripts/script-2-5fjfr: line 13: /usr/bin/jq:
Argument list too long
+ RESULTS_JSON=

Assisted-by: Cursor
Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb requested a review from a team as a code owner July 10, 2025 15:45
@konflux-ci-qe-bot
Copy link

@scoheb: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-catalog-fkvvd Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-fkvvd

Test results analysis

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

➡️ [failed] [It] [release-pipelines-suite e2e tests for rhtap-service-push pipeline] Rhtap-service-push happy path Post-release verification verifies the rhtap release pipelinerun is running and succeeds [release-pipelines, rhtap-service-push, RhtapServicePush]

Click to view logs

PipelineRun managed-fsx2k failed
Expected
    : Pipelinerun 'managed-fsx2k' didn't succeed\nLogs from failed container 'managed-fsx2k-update-cr-status/step-update-cr-status': \n++ mktemp\n+ RESULTS_JSON_FILE=/tmp/tmp.lkiIx8und7\n+ echo '{}'\n+ RESULTS_DIR=/var/workdir/release/f0828467-e809-48a5-a644-5521989eb314/results\n++ '[' -d /var/workdir/release/f0828467-e809-48a5-a644-5521989eb314/results ']'\n++ find /var/workdir/release/f0828467-e809-48a5-a644-5521989eb314/results -type f\n+ for resultsFile in $([ -d \"$RESULTS_DIR\" ] && find \"$RESULTS_DIR\" -type f)\n+ jq . /var/workdir/release/f0828467-e809-48a5-a644-5521989eb314/results/push-snapshot-results.json\n++ mktemp\n+ TMP_RESULT=/tmp/tmp.GNmxPUf5EG\n+ jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.lkiIx8und7\n++ jq -c . /var/workdir/release/f0828467-e809-48a5-a644-5521989eb314/results/push-snapshot-results.json\njq: error (at /tmp/tmp.lkiIx8und7:1): object ({}) and array ([{\"images\":...) cannot be multiplied\n
to equal
    : 

➡️ [failed] [It] [release-pipelines-suite e2e tests for rh-push-to-redhat-io pipeline] Rh-push-to-redhat-io happy path Post-release verification verifies the rhio release pipelinerun is running and succeeds [release-pipelines, rh-push-to-registry-redhat-io, PushToRedhatIO]

Click to view logs

PipelineRun managed-t9252 failed
Expected
    : Pipelinerun 'managed-t9252' didn't succeed\nLogs from failed container 'managed-t9252-update-cr-status/step-update-cr-status': \n++ mktemp\n+ RESULTS_JSON_FILE=/tmp/tmp.tLK31XSE7w\n+ echo '{}'\n+ RESULTS_DIR=/var/workdir/release/3646e85e-54a4-43d8-94bd-41d3c3a0b03b/results\n++ '[' -d /var/workdir/release/3646e85e-54a4-43d8-94bd-41d3c3a0b03b/results ']'\n++ find /var/workdir/release/3646e85e-54a4-43d8-94bd-41d3c3a0b03b/results -type f\n+ for resultsFile in $([ -d \"$RESULTS_DIR\" ] && find \"$RESULTS_DIR\" -type f)\n+ jq . /var/workdir/release/3646e85e-54a4-43d8-94bd-41d3c3a0b03b/results/push-snapshot-results.json\n++ mktemp\n+ TMP_RESULT=/tmp/tmp.iaxaVTlzmh\n+ jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.tLK31XSE7w\n++ jq -c . /var/workdir/release/3646e85e-54a4-43d8-94bd-41d3c3a0b03b/results/push-snapshot-results.json\njq: error (at /tmp/tmp.tLK31XSE7w:1): object ({}) and array ([{\"images\":...) cannot be multiplied\n
to equal
    : 

➡️ [failed] [It] [release-pipelines-suite e2e tests for multi arch with rh-advisories pipeline] Multi arch test happy path Post-release verification verifies the multiarch release pipelinerun is running and succeeds [release-pipelines, rh-advisories, multiarch-advisories, multiArchAdvisories]

Click to view logs

PipelineRun managed-qdrmx failed
Expected
    : Pipelinerun 'managed-qdrmx' didn't succeed\nLogs from failed container 'managed-qdrmx-create-pyxis-image/step-create-trusted-artifact': \n2025/07/10 16:24:19 Skipping step because a previous step failed\n
to equal
    : 

➡️ [failed] [It] [release-pipelines-suite e2e tests for rh-advisories pipeline] Rh-advisories happy path Post-release verification verifies the advs release pipelinerun is running and succeeds [release-pipelines, rh-advisories, rhAdvisories]

Click to view logs

PipelineRun managed-kmpcb failed
Expected
    : Pipelinerun 'managed-kmpcb' didn't succeed\nLogs from failed container 'managed-kmpcb-update-cr-status/step-update-cr-status': \n++ mktemp\n+ RESULTS_JSON_FILE=/tmp/tmp.04NNlCgH4E\n+ echo '{}'\n+ RESULTS_DIR=/var/workdir/release/26fb52db-f8ce-4061-b576-c5cb80cd6ecf/results\n++ '[' -d /var/workdir/release/26fb52db-f8ce-4061-b576-c5cb80cd6ecf/results ']'\n++ find /var/workdir/release/26fb52db-f8ce-4061-b576-c5cb80cd6ecf/results -type f\n+ for resultsFile in $([ -d \"$RESULTS_DIR\" ] && find \"$RESULTS_DIR\" -type f)\n+ jq . /var/workdir/release/26fb52db-f8ce-4061-b576-c5cb80cd6ecf/results/push-snapshot-results.json\n++ mktemp\n+ TMP_RESULT=/tmp/tmp.OQGhbEQIOj\n+ jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.04NNlCgH4E\n++ jq -c . /var/workdir/release/26fb52db-f8ce-4061-b576-c5cb80cd6ecf/results/push-snapshot-results.json\njq: error (at /tmp/tmp.04NNlCgH4E:1): object ({}) and array ([{\"images\":...) cannot be multiplied\n
to equal
    : 

➡️ [failed] [It] [release-pipelines-suite Push to external registry] Post-release verification verifies that Release PipelineRun should eventually succeed [release-pipelines, push-to-external-registry]

Click to view logs

Error when waiting for a release pipelinerun for release ex-registry/snapshot-sample-xhfy-x4rzp to finish
Expected success, but got an error:
    <*errors.errorString | 0xc0009f0770>: 
    Pipelinerun 'managed-5vxvc' didn't succeed
    Logs from failed container 'managed-5vxvc-update-cr-status/step-update-cr-status': 
    ++ mktemp
    + RESULTS_JSON_FILE=/tmp/tmp.havdoGtoFg
    + echo '{}'
    + RESULTS_DIR=/var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results
    ++ '[' -d /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results ']'
    ++ find /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results -type f
    + for resultsFile in $([ -d "$RESULTS_DIR" ] && find "$RESULTS_DIR" -type f)
    + jq . /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results/push-snapshot-results.json
    ++ mktemp
    + TMP_RESULT=/tmp/tmp.Zdmino7aQQ
    + jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.havdoGtoFg
    ++ jq -c . /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results/push-snapshot-results.json
    jq: error (at /tmp/tmp.havdoGtoFg:1): object ({}) and array ([{"images":...) cannot be multiplied
    
    {
        s: "Pipelinerun 'managed-5vxvc' didn't succeed\nLogs from failed container 'managed-5vxvc-update-cr-status/step-update-cr-status': \n++ mktemp\n+ RESULTS_JSON_FILE=/tmp/tmp.havdoGtoFg\n+ echo '{}'\n+ RESULTS_DIR=/var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results\n++ '[' -d /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results ']'\n++ find /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results -type f\n+ for resultsFile in $([ -d \"$RESULTS_DIR\" ] && find \"$RESULTS_DIR\" -type f)\n+ jq . /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results/push-snapshot-results.json\n++ mktemp\n+ TMP_RESULT=/tmp/tmp.Zdmino7aQQ\n+ jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.havdoGtoFg\n++ jq -c . /var/workdir/release/d60d7884-2d33-4829-bbc3-5cfdc54cf058/results/push-snapshot-results.json\njq: error (at /tmp/tmp.havdoGtoFg:1): object ({}) and array ([{\"images\":...) cannot be multiplied\n",
    }

➡️ [failed] [It] [release-pipelines-suite [HACBS-1571]test-release-e2e-push-image-to-pyxis] Post-release verification verifies a release PipelineRun is started and succeeded in managed namespace [release-pipelines, rh-push-to-external-registry]

Click to view logs

Error when waiting for a release pipelinerun for release push-pyxis/snapshot-sample-obzk-885pm to finish
Expected success, but got an error:
    <*errors.errorString | 0xc00083e410>: 
    Pipelinerun 'managed-gf776' didn't succeed
    Logs from failed container 'managed-gf776-update-cr-status/step-update-cr-status': 
    ++ mktemp
    + RESULTS_JSON_FILE=/tmp/tmp.qvagnEcBur
    + echo '{}'
    + RESULTS_DIR=/var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results
    ++ '[' -d /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results ']'
    ++ find /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results -type f
    + for resultsFile in $([ -d "$RESULTS_DIR" ] && find "$RESULTS_DIR" -type f)
    + jq . /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results/push-snapshot-results.json
    ++ mktemp
    + TMP_RESULT=/tmp/tmp.IjPzFKCOWW
    + jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.qvagnEcBur
    ++ jq -c . /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results/push-snapshot-results.json
    jq: error (at /tmp/tmp.qvagnEcBur:1): object ({}) and array ([{"images":...) cannot be multiplied
    
    {
        s: "Pipelinerun 'managed-gf776' didn't succeed\nLogs from failed container 'managed-gf776-update-cr-status/step-update-cr-status': \n++ mktemp\n+ RESULTS_JSON_FILE=/tmp/tmp.qvagnEcBur\n+ echo '{}'\n+ RESULTS_DIR=/var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results\n++ '[' -d /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results ']'\n++ find /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results -type f\n+ for resultsFile in $([ -d \"$RESULTS_DIR\" ] && find \"$RESULTS_DIR\" -type f)\n+ jq . /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results/push-snapshot-results.json\n++ mktemp\n+ TMP_RESULT=/tmp/tmp.IjPzFKCOWW\n+ jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.qvagnEcBur\n++ jq -c . /var/workdir/release/afe498be-668c-4205-8d13-4026b28233b1/results/push-snapshot-results.json\njq: error (at /tmp/tmp.qvagnEcBur:1): object ({}) and array ([{\"images\":...) cannot be multiplied\n",
    }

➡️ [failed] [It] [release-pipelines-suite FBC e2e-tests] with FBC happy path Post-release verification verifies the fbc release pipelinerun is running and succeeds [release-pipelines, fbc-release, fbcHappyPath]

Click to view logs

PipelineRun managed-rz7sg failed
Expected
    : Pipelinerun 'managed-rz7sg' didn't succeed\nLogs from failed container 'managed-rz7sg-update-cr-status/step-update-cr-status': \n++ mktemp\n+ RESULTS_JSON_FILE=/tmp/tmp.XiZeswvP4F\n+ echo '{}'\n+ RESULTS_DIR=/var/workdir/release/ac99ed35-fa90-4e0b-94be-18bb4c72e044/results\n++ '[' -d /var/workdir/release/ac99ed35-fa90-4e0b-94be-18bb4c72e044/results ']'\n++ find /var/workdir/release/ac99ed35-fa90-4e0b-94be-18bb4c72e044/results -type f\n+ for resultsFile in $([ -d \"$RESULTS_DIR\" ] && find \"$RESULTS_DIR\" -type f)\n+ jq . /var/workdir/release/ac99ed35-fa90-4e0b-94be-18bb4c72e044/results/internal-requests-results.json\n++ mktemp\n+ TMP_RESULT=/tmp/tmp.IIWD6FCvS7\n+ jq -c '. * $newData' --slurpfile newData /dev/fd/63 /tmp/tmp.XiZeswvP4F\n++ jq -c . /var/workdir/release/ac99ed35-fa90-4e0b-94be-18bb4c72e044/results/internal-requests-results.json\njq: error (at /tmp/tmp.XiZeswvP4F:1): object ({}) and array ([{\"index_im...) cannot be multiplied\n
to equal
    : 

@johnbieren
Copy link
Collaborator

unit test failure appears legit

@scoheb
Copy link
Member Author

scoheb commented Jul 10, 2025

unit test failure appears legit

yes. @arewm is working on continuing with a subsequent fix

@scoheb
Copy link
Member Author

scoheb commented Jul 11, 2025

closing in favour of @arewm upcoming PR

@scoheb scoheb closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants