Skip to content

fix: protect against large advisory_json values #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scoheb
Copy link
Member

@scoheb scoheb commented Jul 7, 2025

Describe your changes

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting

@scoheb scoheb requested a review from a team as a code owner July 7, 2025 02:48
seanconroy2021
seanconroy2021 previously approved these changes Jul 7, 2025
@openshift-ci openshift-ci bot added the lgtm label Jul 7, 2025
@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from ba850e8 to 18b3ffd Compare July 8, 2025 14:15
@openshift-ci openshift-ci bot removed the lgtm label Jul 8, 2025
@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch 3 times, most recently from cc03345 to d95b7fd Compare July 8, 2025 15:00
@scoheb scoheb marked this pull request as draft July 8, 2025 15:06
@scoheb
Copy link
Member Author

scoheb commented Jul 8, 2025

depends on konflux-ci/release-service-utils#473

@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from d95b7fd to 5a50ac1 Compare July 8, 2025 15:12
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once utils pr is merged and image ref is updated

@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from 5a50ac1 to 7cbd1aa Compare July 11, 2025 13:35
@scoheb scoheb marked this pull request as ready for review July 11, 2025 13:35
@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2025
@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from 7cbd1aa to badc3b0 Compare July 11, 2025 15:31
@openshift-ci openshift-ci bot removed the lgtm label Jul 11, 2025
Copy link

openshift-ci bot commented Jul 11, 2025

New changes are detected. LGTM label has been removed.

@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from badc3b0 to 02fdc9f Compare July 11, 2025 16:21
@arewm
Copy link
Member

arewm commented Jul 11, 2025

/retest

@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from 02fdc9f to db89207 Compare July 11, 2025 21:05
@scoheb scoheb enabled auto-merge (squash) July 11, 2025 21:05
@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from db89207 to 4a583a4 Compare July 12, 2025 14:21
@scoheb
Copy link
Member Author

scoheb commented Jul 12, 2025

/retest

1 similar comment
@scoheb
Copy link
Member Author

scoheb commented Jul 12, 2025

/retest

- update to latest release-service-utils-image

Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb force-pushed the fix-arg-too-long-create-advisory branch from 4a583a4 to faf33eb Compare July 12, 2025 19:42
@scoheb
Copy link
Member Author

scoheb commented Jul 12, 2025

/retest

@scoheb scoheb merged commit a245668 into konflux-ci:development Jul 12, 2025
17 checks passed
arewm pushed a commit to arewm/release-service-catalog that referenced this pull request Jul 14, 2025
- update to latest release-service-utils-image

Signed-off-by: Scott Hebert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants