Skip to content

fix: misc krw fixes #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

fix: misc krw fixes #1177

merged 1 commit into from
Jul 4, 2025

Conversation

scoheb
Copy link
Member

@scoheb scoheb commented Jul 4, 2025

Describe your changes

  • add export for originating_tool.
    this is needed for that the value is inserted
    into the resources
  • be lenient on error with resource cleanup
  • add pyxis secret to SA secret list
  • only cleanup resources that are older than
    24 hours
  • correct default for delete old branches script
  • refresh vaults

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting

@scoheb scoheb requested a review from a team as a code owner July 4, 2025 14:06
@scoheb scoheb enabled auto-merge (squash) July 4, 2025 14:38
@scoheb
Copy link
Member Author

scoheb commented Jul 4, 2025

/retest

seanconroy2021
seanconroy2021 previously approved these changes Jul 4, 2025
Copy link

openshift-ci bot commented Jul 4, 2025

New changes are detected. LGTM label has been removed.

@scoheb scoheb changed the title fix: add export for originating_tool fix: misc krw fixes Jul 4, 2025
@scoheb
Copy link
Member Author

scoheb commented Jul 4, 2025

/retest

1 similar comment
@scoheb
Copy link
Member Author

scoheb commented Jul 4, 2025

/retest

@scoheb scoheb force-pushed the fix-krw-export branch 2 times, most recently from cc00fcc to d00e703 Compare July 4, 2025 17:14
- add export for originating_tool.
  this is needed for that the value is inserted
  into the resources
- be lenient on error with resource cleanup
- add pyxis secret to SA secret list
- only cleanup resources that are older than
  24 hours
- correct default for delete old branches script
- refresh vaults

Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb disabled auto-merge July 4, 2025 18:40
@scoheb scoheb merged commit 6df1b4f into konflux-ci:development Jul 4, 2025
15 checks passed
@happybhati
Copy link
Contributor

❗Promoted to staging ❗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants