fix(RELEASE-1728): rh-sign-image optimization #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoheb
force-pushed
the
find-signatures-parallel
branch
from
36b7290 to
2228685
Compare
scoheb
changed the title
scoheb
force-pushed
the
find-signatures-parallel
branch
2 times, most recently
from
98c56e1 to
c864295
Compare
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
c864295 to
9b46054
Compare
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
9b46054 to
4e7c843
Compare
johnbieren
previously approved these changes
Jul 9, 2025
scoheb
force-pushed
the
find-signatures-parallel
branch
from
4e7c843 to
99f0f20
Compare
scoheb
force-pushed
the
find-signatures-parallel
branch
2 times, most recently
from
ef22545 to
35672fe
Compare
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
3 times, most recently
from
eccf6a4 to
c4cda31
Compare
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
c4cda31 to
75f6e79
Compare
|
/retest |
1 similar comment
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
2 times, most recently
from
6c71ca2 to
47a3578
Compare
|
/retest |
1 similar comment
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
47a3578 to
c05bb00
Compare
|
This PR seems to be breaking the functionality when I am testing it. With this change, it is trying to sign only tags/digests. The repositories are not present in the requests. |
scoheb
force-pushed
the
find-signatures-parallel
branch
3 times, most recently
from
7946bac to
344e391
Compare
|
successfully tested by @arewm on OCP releases for both new and old snapshots. |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
344e391 to
b64c29a
Compare
|
/retest |
1 similar comment
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
b64c29a to
16b58d6
Compare
seanconroy2021
approved these changes
Jul 16, 2025
|
/retest |
scoheb
force-pushed
the
find-signatures-parallel
branch
from
16b58d6 to
e633963
Compare
|
New changes are detected. LGTM label has been removed. |
- parallelize calls to find-signature in an effort to improve performance. Assisted-by: Cursor Signed-off-by: Scott Hebert <[email protected]>
scoheb
force-pushed
the
find-signatures-parallel
branch
from
e633963 to
9928b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
JIRA issue
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>