Skip to content

fix: add retries to github merges #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

scoheb
Copy link
Member

@scoheb scoheb commented Jul 2, 2025

Describe your changes

  • recently saw a 405 error when trying to merge a PR.
  • it could point to a timing issue
  • added a retry loop with better error response handling for improved debugging

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting

- recently saw a 405 error when trying to merge
  a PR.
- it could point to a timing issue
- added a retry loop with better error response
  handling for improved debugging

Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb requested a review from a team as a code owner July 2, 2025 12:48
@openshift-ci openshift-ci bot added the lgtm label Jul 2, 2025
@scoheb scoheb merged commit 3f805fa into konflux-ci:development Jul 2, 2025
15 checks passed
@mmalina
Copy link
Contributor

mmalina commented Jul 2, 2025

Nice!

@happybhati
Copy link
Contributor

❗ Promoted to production ❗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants